polkadot-parachain: add manual seal support#5586
Merged
serban300 merged 15 commits intoOct 2, 2024
Merged
Conversation
serban300
added
R0-no-crate-publish-required
kianenigma
reviewed
Sep 4, 2024
kianenigma
reviewed
Sep 4, 2024
skunert
reviewed
Sep 10, 2024
skunert
left a comment
skunert
left a comment
Contributor
There was a problem hiding this comment.
Did not look at the manual_seal.rs code itself yet, will make one more pass.
skunert
reviewed
Sep 25, 2024
kianenigma
reviewed
Oct 1, 2024
kianenigma
approved these changes
Oct 1, 2024
kianenigma
left a comment
kianenigma
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming all open discussions are well addressed and closed :)
Contributor
|
Final request: PR description also seems out of date wrt example 🙏 |
kianenigma
reviewed
Oct 2, 2024
Contributor
Author
Sorry, missed it. Done. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Removing the shell node variant for the polkadot-parachain as discussed here: #5586 (comment) Resolves #5898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5026
This PR adds support for starting a dev node with manual seal consensus. This can be done by using the
--dev-block-timeargument . For example: