Bridges lane id agnostic for backwards compatibility#5649
Merged
Conversation
72db319 to
adf682e
Compare
9b9c36a to
c0c2d54
Compare
c0c2d54 to
8f2ae83
Compare
2 tasks
fdd9948 to
d5dc6f4
Compare
Introduce LegacyLaneId
d5dc6f4 to
bebaba1
Compare
serban300
approved these changes
Sep 24, 2024
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5649-to-stable2407
git worktree add --checkout .worktree/backport-5649-to-stable2407 backport-5649-to-stable2407
cd .worktree/backport-5649-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 710e74ddefdff1e36b77ba65abe54feb0ac15040
git push --force-with-lease |
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5649-to-stable2409
git worktree add --checkout .worktree/backport-5649-to-stable2409 backport-5649-to-stable2409
cd .worktree/backport-5649-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 710e74ddefdff1e36b77ba65abe54feb0ac15040
git push --force-with-lease |
bkontur
added a commit
that referenced
this pull request
Sep 24, 2024
This PR primarily fixes the issue with `zombienet-bridges-0001-asset-transfer-works` (see: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7404903). The PR looks large, but most of the changes involve splitting `LaneId` into `LegacyLaneId` and `HashedLaneId`. All pallets now use `LaneId` as a generic parameter. The actual bridging pallets are now backward compatible and work with actual **substrate-relay v1.6.10**, which does not even known anything about permissionless lanes or the new pallet changes. - [x] added migration for `pallet_bridge_relayers` and `RewardsAccountParams` change order of params, which generates different accounts - [ ] fix monitoring for `at_{}_relay_{}_reward_for_msgs_from_{}_on_lane_{}` - [ ] check sovereign reward accounts - because of changed `RewardsAccountParams` - [ ] deploy another messages instances for permissionless lanes - on BHs or AHs? - [ ] return back `open_and_close_bridge_works` for another `pallet-bridge-messages` instance --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> (cherry picked from commit 710e74d)
EgorPopelyaev
pushed a commit
that referenced
this pull request
Sep 25, 2024
Backport #5649 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
pandres95
added a commit
to pandres95/runtimes
that referenced
this pull request
Oct 19, 2024
…polkadot-sdk#4488] (SDK #4935)[paritytech/polkadot-sdk#4935] (SDK #4949)[paritytech/polkadot-sdk#4949] (SDK #5649)[paritytech/polkadot-sdk#5649] - Configure Polkadot Asset Hub - Configure Bridge Hubs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily fixes the issue with
zombienet-bridges-0001-asset-transfer-works(see: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7404903).The PR looks large, but most of the changes involve splitting
LaneIdintoLegacyLaneIdandHashedLaneId. All pallets now useLaneIdas a generic parameter.The actual bridging pallets are now backward compatible and work with actual substrate-relay v1.6.10, which does not even known anything about permissionless lanes or the new pallet changes.
Important
pallet_bridge_relayersandRewardsAccountParamschange order of params, which generates different accountsDeployment follow ups
at_{}_relay_{}_reward_for_msgs_from_{}_on_lane_{}RewardsAccountParamsopen_and_close_bridge_worksfor anotherpallet-bridge-messagesinstance