Added foreign locations to local accounts converter to all the parachains#5765
Conversation
acatangiu
left a comment
There was a problem hiding this comment.
Request changes
Do not remove existing converters to maintain backwards compatibility (see following comments)
Testing
For each chain/runtime, please add unit tests (faster/easier than emulated tests) that cover the newly supported conversions.
E.g. you can add new test for asset-hub-westend here, then run it with cargo test -r -p asset-hub-westend-runtime. Do the same for other runtimes too.
In terms of how to test, very easy way is using LocationToAccountHelper::convert_location()` and pass it locations that use to fail conversion, but with your change now succeed.
You can see an example of how to call LocationToAccountHelper here.
|
bot fmt |
…xcm_config.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Added the tests. Additionally removed my change and made sure that the tests fail. |
Added location convertion tests. Polkadot sdk [PR](paritytech/polkadot-sdk#5765) Fixes #488
Added
HashedDescription<AccountId, DescribeFamily<DescribeAllTerminal>>foreign locations to local accounts converter to all the parachains.