Skip to content

Migrate pallet-im-online benchmark to v2#6295

Merged
re-gius merged 8 commits into
paritytech:masterfrom
aurexav:benchmarkv2-imonline
Nov 5, 2024
Merged

Migrate pallet-im-online benchmark to v2#6295
re-gius merged 8 commits into
paritytech:masterfrom
aurexav:benchmarkv2-imonline

Conversation

@aurexav

@aurexav aurexav commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

@aurexav aurexav requested a review from a team as a code owner October 30, 2024 15:20
@aurexav aurexav mentioned this pull request Oct 30, 2024
44 tasks
@ggwpez

ggwpez commented Oct 30, 2024

Copy link
Copy Markdown
Member

/cmd prdoc --bump patch --audience runtime_dev

@ggwpez ggwpez added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Oct 30, 2024

@re-gius re-gius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Comment thread substrate/frame/im-online/src/benchmarking.rs Outdated
Comment thread substrate/frame/im-online/src/benchmarking.rs Outdated
Comment thread substrate/frame/im-online/src/benchmarking.rs Outdated
@re-gius re-gius added this pull request to the merge queue Nov 5, 2024
Merged via the queue into paritytech:master with commit 8b6c6eb Nov 5, 2024
@re-gius

re-gius commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

/tip small

@substrate-tip-bot

Copy link
Copy Markdown

Tip for 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y referendum status is 👎: InvalidTxError: {
"type": "Invalid",
"value": {
"type": "Stale"
}
}

@re-gius

re-gius commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

/tip small

@substrate-tip-bot

Copy link
Copy Markdown

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @AurevoirXavier (156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y on polkadot).

Referendum number: 1292.
tip

@substrate-tip-bot

Copy link
Copy Markdown

The referendum has appeared on Polkassembly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants