Skip to content

Migrate pallet-recovery to umbrella crate#6894

Closed
Krayt78 wants to merge 5 commits into
paritytech:masterfrom
Krayt78:migrate-pallet-recovery-to-umbrella-crate
Closed

Migrate pallet-recovery to umbrella crate#6894
Krayt78 wants to merge 5 commits into
paritytech:masterfrom
Krayt78:migrate-pallet-recovery-to-umbrella-crate

Conversation

@Krayt78
Copy link
Copy Markdown
Contributor

@Krayt78 Krayt78 commented Dec 13, 2024

Part of #6504

@Krayt78 Krayt78 marked this pull request as ready for review December 15, 2024 15:54
@Krayt78 Krayt78 requested a review from a team as a code owner December 15, 2024 15:54
@re-gius re-gius added R0-no-crate-publish-required The change does not require any crates to be re-published. T2-pallets This PR/Issue is related to a particular pallet. labels Dec 17, 2024
Copy link
Copy Markdown
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krayt78 Krayt78 requested a review from re-gius December 17, 2024 15:25
@Krayt78
Copy link
Copy Markdown
Contributor Author

Krayt78 commented Dec 17, 2024

LGTM but please address this CI error on TOML formatting

https://github.com/paritytech/polkadot-sdk/actions/runs/12340213124/job/34437402975?pr=6894

fixed it

@Krayt78
Copy link
Copy Markdown
Contributor Author

Krayt78 commented Apr 25, 2025

@UtkarshBhardwaj007 is there anything that i did in this PR that isnt in you PR that got merged 3 days ago ? #7882

@Krayt78
Copy link
Copy Markdown
Contributor Author

Krayt78 commented Apr 25, 2025

Looking at the conflicts i guess this PR can be thrown away, @re-gius you can update on the main thread that the pallet-recovery got merged with PR #7882
I guess i should spam on element to get my PRs approved :')

@Krayt78 Krayt78 closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants