Skip to content

[stable2412] Backport #6855#7090

Merged
EgorPopelyaev merged 3 commits into
stable2412from
backport-6855-to-stable2412
Jan 14, 2025
Merged

[stable2412] Backport #6855#7090
EgorPopelyaev merged 3 commits into
stable2412from
backport-6855-to-stable2412

Conversation

@paritytech-cmd-bot-polkadot-sdk

Copy link
Copy Markdown
Contributor

Backport #6855 into stable2412 from alistair-singh.

See the documentation on how to use this bot.

Changes:
1. Use the 0x0000000000000000000000000000000000000000 token address as
Native ETH.
2. Convert it to/from `{ parents: 2, interior:
X1(GlobalConsensus(Ethereum{chain_id: 1})) }` when encountered.

Onchain changes:
This will require a governance request to register native ETH (with the
above location) in the foreign assets pallet and make it sufficient.

Related solidity changes:
Snowfork/snowbridge#1354

TODO:
- [x] Emulated Tests

---------

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <info@kchr.de>
(cherry picked from commit 4059282)
@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 8, 2025
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team January 8, 2025 14:21
@acatangiu

Copy link
Copy Markdown
Contributor

cc @alistair-singh

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 9eb6fc8 into stable2412 Jan 14, 2025
@EgorPopelyaev EgorPopelyaev deleted the backport-6855-to-stable2412 branch January 14, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants