xcm: avoid subtracting delivery fees twice

[carlosala]

At the moment, the delivery fees are being subtracted twice if the jit_withdraw mode is enabled, resulting in assets being trapped. This is an example of it.
This does not happen in 2412 anymore after #4834.

[carlosala]

/cmd prdoc --audience runtime_dev --bump patch

[github-actions]

Sorry, only members of the organization paritytech members can run commands.

[bkchr]

CC @franciscoaguirre

[bkchr]

@carlosala could we maybe get some test for this? :D (Not sure how the test infrastructure looks right now)

[carlosala]

I'm not really sure either, what do you think @franciscoaguirre?

[acatangiu]

AFAIK there is no test verifying the right delivery fee being charged - aka there are tests verifying fees are charged but not asserting on amounts.

But there are already many tests verifying that DepositReserveAsset is working under various conditions, so any breakage would be caught. CI should be green for this PR.

[franciscoaguirre]

/cmd fmt

[github-actions]

Command "fmt" has started 🚀 See logs here

[github-actions]

Command "fmt" has failed ❌! See logs here

[franciscoaguirre]

/cmd fmt

[github-actions]

Command "fmt" has started 🚀 See logs here

[github-actions]

Command "fmt" has failed ❌! See logs here

[franciscoaguirre]

bot fmt

[command-bot]

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8058462 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-c6e70445-eda5-4839-b604-4dc2569a4536 to cancel this command or bot cancel to cancel all commands in this pull request.

[github-actions]

We have migrated the command bot to GHA

Please, see the new usage instructions here or here. Soon the old commands will be disabled.

[command-bot]

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8058462 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8058462/artifacts/download.

[acatangiu]

The following 7 benchmarks failed:

• pallet_xcm::force_subscribe_version_notify
• pallet_xcm::force_unsubscribe_version_notify
• pallet_xcm::send
• pallet_xcm::transfer_assets
• pallet_xcm_benchmarks::fungible::deposit_asset
• pallet_xcm_benchmarks::fungible::deposit_reserve_asset
• pallet_xcm_benchmarks::fungible::initiate_teleport

Please verify that these tests are passing for you locally (cargo test -p pallet-xcm --features=runtime-benchmarks)

Also please verify XCM emulated tests are passing locally:

cargo test -r -p asset-hub-westend-integration-tests -p bridge-hub-westend-integration-tests

[athei]

Your editor seems to be reformatting unrelated files. Please re-run fmt (using the bot if you want) and fix your editor.

[carlosala]

The unrelated files were changes by the bot, after bot fmt run by @franciscoaguirre

[athei]

Okay not sure what is wrong with the bot. Maybe it is on an old version. We should not use it anymore I guess in favor of /cmd. But this seems to be broken in a different way. Sorry for insulting your editor :D

[carlosala]

XCM emulated tests are passing as expected to me locally 👍🏻

Please verify that these tests are passing for you locally (cargo test -p pallet-xcm --features=runtime-benchmarks)

They are not compiling due to a compilation error in the staking pallet. I have the same compilation error on stable2409 branch 👍🏻

[Polkadot-Forum]

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-api-2025-q1-update/11906/1