YAP NG FTW!

[s0me0ne-unkn0wn]

Yet Another Parachain ported onto the latest master branch.

[sandreim]

Thanks @s0me0ne-unkn0wn

[s0me0ne-unkn0wn]

bot fmt

[command-bot]

@s0me0ne-unkn0wn https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8044841 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-9f45d480-7e4c-4655-84bb-0e291255751e to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@s0me0ne-unkn0wn Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8044841 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/8044841/artifacts/download.

[georgepisaltu]

I replaced the use of ExtrinsicBaseWeight, which double counted the weight of all extensions in the transaction extension pipeline, with the weight of a signature check, the only thing not covered by transaction extensions in v4 extrinsics. This weight is approximated by the weight of the VerifySignature extension, which is usually useful only in v5 extrinsics. In this case, we use its benchmarked weight as the base extrinsic weight. I used the weight benchmarked within the substrate node, but you could benchmark this again or tweak it even further.

[s0me0ne-unkn0wn]

@georgepisaltu Thanks a lot, very much appreciated!

[sandreim]

We should review/finish/merge this PR and have this chain read for next spammening. I got 3k+ txs per block in my tests.

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/14459636959
Failed job name: check-runtime-migration

[michalkucharczyk]

Is it supposed to demo elastic-scaling and work with 2s blocks?
If so, would be great to see some zombienet configuration enabling this setup (I guess you already have something to test it).
I could then check where are we with the pool performance.

[ordian]

Is it supposed to demo elastic-scaling and work with 2s blocks? If so, would be great to see some zombienet configuration enabling this setup (I guess you already have something to test it). I could then check where are we with the pool performance.

We already have a zombienet-sdk test with elastic scaling in master. You'd need to modify para setup to use yap runtime and then can use stps script or your own tool to stress test the parachain.

[michalkucharczyk]

We already have a zombienet-sdk test with elastic scaling in master. You'd need to modify para setup to use yap runtime and then can use stps script or your own tool to stress test the parachain.

Thank you for this info! Would you mind sharing a small snippet of how the modified para setup should look like when using the yap runtime? That would be super helpful and probably will save some time on my side.

[ordian]

diff --git a/polkadot/zombienet-sdk-tests/tests/elastic_scaling/slot_based_3cores.rs b/polkadot/zombienet-sdk-tests/tests/elastic_scaling/slot_based_3cores.rs
index 422feb4d20c..dfdc3d5ddc5 100644
--- a/polkadot/zombienet-sdk-tests/tests/elastic_scaling/slot_based_3cores.rs
+++ b/polkadot/zombienet-sdk-tests/tests/elastic_scaling/slot_based_3cores.rs
@@ -34,9 +34,9 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
 					"configuration": {
 						"config": {
 							"scheduler_params": {
-								// Num cores is 4, because 2 extra will be added automatically when registering the paras.
-								"num_cores": 4,
-								"max_validators_per_core": 2
+								// Num cores is 2, because 1 extra will be added automatically when registering the para.
+								"num_cores": 2,
+								"max_validators_per_core": 1
 							}
 						}
 					}
@@ -45,31 +45,23 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
 				// type.
 				.with_node(|node| node.with_name("validator-0"));
 
-			(1..12)
+			(1..3)
 				.fold(r, |acc, i| acc.with_node(|node| node.with_name(&format!("validator-{i}"))))
 		})
-		.with_parachain(|p| {
-			// Para 2100 uses the old elastic scaling mvp, which doesn't send the new UMP signal
-			// commitment for selecting the core index.
-			p.with_id(2100)
-				.with_default_command("test-parachain")
-				.with_default_image(images.cumulus.as_str())
-				.with_chain("elastic-scaling-mvp")
-				.with_default_args(vec![
-					"--authoring=slot-based".into(),
-					("-lparachain=debug,aura=debug").into(),
-				])
-				.with_collator(|n| n.with_name("collator-elastic-mvp"))
-		})
 		.with_parachain(|p| {
 			// Para 2200 uses the new RFC103-enabled collator which sends the UMP signal commitment
 			// for selecting the core index
 			p.with_id(2200)
-				.with_default_command("test-parachain")
+				.with_default_command("polkadot-parachain")
 				.with_default_image(images.cumulus.as_str())
-				.with_chain("elastic-scaling")
+				.with_chain("yap-rococo-local-2200")
 				.with_default_args(vec![
 					"--authoring=slot-based".into(),
+					"--rpc-max-subscriptions-per-connection=128000".into(),
+					"--rpc-max-connections=128000".into(),
+					"--pool-limit=500000".into(),
+					"--pool-kbytes=2048000".into(),
+					"--pool-type=fork-aware".into(),
 					("-lparachain=debug,aura=debug").into(),
 				])
 				.with_collator(|n| n.with_name("collator-elastic"))
@@ -85,12 +77,11 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
 
 	let relay_node = network.get_node("validator-0")?;
 	let para_node_elastic = network.get_node("collator-elastic")?;
-	let para_node_elastic_mvp = network.get_node("collator-elastic-mvp")?;
 
 	let relay_client: OnlineClient<PolkadotConfig> = relay_node.wait_client().await?;
 	let alice = dev::alice();
 
-	let assign_cores_call = create_assign_core_call(&[(0, 2100), (1, 2100), (2, 2200), (3, 2200)]);
+	let assign_cores_call = create_assign_core_call(&[(0, 2200), (1, 2200)]);
 	// Assign two extra cores to each parachain.
 	relay_client
 		.tx()
@@ -99,27 +90,10 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
 		.wait_for_finalized_success()
 		.await?;
 
-	log::info!("2 more cores assigned to each parachain");
-
-	// Expect a backed candidate count of at least 39 for each parachain in 15 relay chain blocks
-	// (2.6 candidates per para per relay chain block).
-	// Note that only blocks after the first session change and blocks that don't contain a session
-	// change will be counted.
-	assert_para_throughput(
-		&relay_client,
-		15,
-		[(ParaId::from(2100), 39..46), (ParaId::from(2200), 39..46)]
-			.into_iter()
-			.collect(),
-	)
-	.await?;
-
-	// Assert the parachain finalized block height is also on par with the number of backed
-	// candidates.
-	assert_finality_lag(&para_node_elastic.wait_client().await?, 15).await?;
-	assert_finality_lag(&para_node_elastic_mvp.wait_client().await?, 15).await?;
+	log::info!("2 more cores assigned to the parachain");
 
-	log::info!("Test finished successfully");
+	// run the test forever
+	loop {}
 
 	Ok(())
 }

I haven't tested this, but this should work. If you encountered an issue, feel free to DM me :)

[ordian]

Run with ZOMBIE_PROVIDER=native cargo test -r -p polkadot-zombienet-sdk-tests --features zombie-metadata slot_based_3cores. And you'll need to recompile polkadot-parachain from this branch for chainspec generation.