Add view functions to Proxy pallet for runtime-specific type configuration #7297#7320
Conversation
|
Please review @bkchr |
|
Please review @bkchr |
|
As @kianenigma requested in #7297 (comment) I updated the implementation by adding
|
Nathy-bajo
changed the title
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
LGTM, the lock files need to be updated?
The idea of view functions is to be a stable interface as well. The two functions added here seem pretty reasonable to me, but good for other reviewers to also double check that.
|
Review required! Latest push from author must always be reviewed |
I think it was because I updated cargo
|
|
Glad to see this merged🎉 please see my Polkadot address in the description @bkchr |
|
/tip small |
|
@bkchr A referendum for a small (20 DOT) tip was successfully submitted for @Nathy-bajo (121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1 on polkadot). Referendum number: 1446. |
|
The referendum has appeared on Polkassembly. |
…ation paritytech#7297 (paritytech#7320) Solves paritytech#7297 I added a ProxyApi runtime API to the Proxy pallet with two methods: check_permissions: Checks if a RuntimeCall passes a ProxyType's InstanceFilter. is_superset: Verifies if one ProxyType includes another. Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1 --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/private-study-group-runtime-developer-guide/12655/1 |
| proxy_type.filter(&call) | ||
| } | ||
|
|
||
| /// Check if one `ProxyType` is a subset of another `ProxyType`. |
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: |
6 participants
Solves #7297
I added a ProxyApi runtime API to the Proxy pallet with two methods:
check_permissions: Checks if a RuntimeCall passes a ProxyType's InstanceFilter.
is_superset: Verifies if one ProxyType includes another.
Polkadot address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1