Skip to content

[stable2412] Backport #7438#7689

Merged
EgorPopelyaev merged 19 commits into
stable2412from
backport-7438-to-stable2412
Feb 26, 2025
Merged

[stable2412] Backport #7438#7689
EgorPopelyaev merged 19 commits into
stable2412from
backport-7438-to-stable2412

Conversation

@paritytech-cmd-bot-polkadot-sdk

Copy link
Copy Markdown
Contributor

Backport #7438 into stable2412 from mrshiposha.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk

Copy link
Copy Markdown
Contributor Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7438-to-stable2412
git worktree add --checkout .worktree/backport-7438-to-stable2412 backport-7438-to-stable2412
cd .worktree/backport-7438-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 963f0d734e386023957354add6bb1dba62b2776c
git push --force-with-lease

@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 24, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Fixes #7413

This PR updates the `DryRunApi`. The signature of the `dry_run_call` is
changed, and the XCM version of the return values of `dry_run_xcm` now
follows the version of the input XCM program.

* **The `DryRunApi` is modified**
* **Added the `Router::clear_messages` to `dry_run_xcm` common
implementation**
* **Fixed the xcmp-queue's Router's clear_messages: channels details'
first_index and last_index are reset when clearing**
* **The MIN_XCM_VERSION is added**
* The common implementation in the `pallet-xcm` is modified accordingly
* The `DryRunApi` tests are modified to account for testing old XCM
versions
* The implementation from the `pallet-xcm` is used where it was not used
(including the `DryRunApi` tests)
* All the runtime implementations are modified according to the Runtime
API change

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
@raymondkfcheung raymondkfcheung force-pushed the backport-7438-to-stable2412 branch from cb9992c to e73d715 Compare February 25, 2025 11:24
@raymondkfcheung

Copy link
Copy Markdown
Contributor

/cmd fmt

@raymondkfcheung raymondkfcheung marked this pull request as ready for review February 25, 2025 14:25
@raymondkfcheung raymondkfcheung requested a review from a team as a code owner February 25, 2025 14:25
@raymondkfcheung

Copy link
Copy Markdown
Contributor

/cmd fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

Status: Done
Status: To be released (SDK)

Development

Successfully merging this pull request may close these issues.

3 participants