Skip to content

add poke_deposit extrinsic to pallet-recovery #7882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UtkarshBhardwaj007 merged 21 commits into from
Apr 22, 2025
Merged

add poke_deposit extrinsic to pallet-recovery #7882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c1f7ddc
add poke_deposit extrinsic to pallet-recovery
UtkarshBhardwaj007 Mar 11, 2025
7851596
Update from github-actions[bot] running command 'fmt'
github-actions[bot] Mar 11, 2025
edffb29
Update from github-actions[bot] running command 'prdoc'
github-actions[bot] Mar 11, 2025
5a85b3e
add prdoc
UtkarshBhardwaj007 Mar 11, 2025
14d92ad
fix benchmarks
UtkarshBhardwaj007 Mar 11, 2025
85bdd0a
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] Mar 11, 2025
f8b5b1d
Merge branch 'paritytech:master' into poke-recovery
UtkarshBhardwaj007 Mar 24, 2025
c9078c3
improve readability of poke_deposit extrinsic
UtkarshBhardwaj007 Mar 24, 2025
d4b7338
Update from github-actions[bot] running command 'fmt'
github-actions[bot] Mar 24, 2025
a3052c6
remove unnecessary imports
UtkarshBhardwaj007 Mar 25, 2025
771781e
update helper function names
UtkarshBhardwaj007 Mar 26, 2025
a93503d
Merge branch 'paritytech:master' into poke-recovery
UtkarshBhardwaj007 Mar 30, 2025
dff5c83
Update from github-actions[bot] running command 'fmt'
github-actions[bot] Mar 30, 2025
31f7c50
Merge branch 'paritytech:master' into poke-recovery
UtkarshBhardwaj007 Apr 6, 2025
fff01dd
Merge branch 'paritytech:master' into poke-recovery
UtkarshBhardwaj007 Apr 11, 2025
5ea2c2d
fix unbounded iteration
UtkarshBhardwaj007 Apr 11, 2025
d8858af
Update from github-actions[bot] running command 'fmt'
github-actions[bot] Apr 11, 2025
a56c3ef
Merge branch 'paritytech:master' into poke-recovery
UtkarshBhardwaj007 Apr 16, 2025
d66c25e
check for events in benchmarking
UtkarshBhardwaj007 Apr 16, 2025
fdba191
Update from github-actions[bot] running command 'bench --pallet palle…
github-actions[bot] Apr 16, 2025
81a84f8
Merge branch 'master' into poke-recovery
ggwpez Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

77 changes: 47 additions & 30 deletions polkadot/runtime/rococo/src/weights/pallet_recovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
//! Autogenerated weights for `pallet_recovery`
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0
//! DATE: 2025-02-21, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2025-04-16, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
//! HOSTNAME: `d3a9aad6f7a3`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! HOSTNAME: `25e4b24639fd`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! WASM-EXECUTION: `Compiled`, CHAIN: `None`, DB CACHE: 1024

// Executed Command:
Expand Down Expand Up @@ -57,8 +57,8 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `215`
// Estimated: `3545`
// Minimum execution time: 10_736_000 picoseconds.
Weight::from_parts(11_094_000, 0)
// Minimum execution time: 9_790_000 picoseconds.
Weight::from_parts(10_384_000, 0)
.saturating_add(Weight::from_parts(0, 3545))
.saturating_add(T::DbWeight::get().reads(1))
}
Expand All @@ -68,8 +68,8 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 7_443_000 picoseconds.
Weight::from_parts(7_913_000, 0)
// Minimum execution time: 7_285_000 picoseconds.
Weight::from_parts(7_702_000, 0)
.saturating_add(Weight::from_parts(0, 0))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -80,11 +80,11 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `109`
// Estimated: `3816`
// Minimum execution time: 25_150_000 picoseconds.
Weight::from_parts(26_615_594, 0)
// Minimum execution time: 24_418_000 picoseconds.
Weight::from_parts(25_349_045, 0)
.saturating_add(Weight::from_parts(0, 3816))
// Standard Error: 5_595
.saturating_add(Weight::from_parts(107_935, 0).saturating_mul(n.into()))
// Standard Error: 6_323
.saturating_add(Weight::from_parts(183_712, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -96,8 +96,8 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `206`
// Estimated: `3854`
// Minimum execution time: 29_962_000 picoseconds.
Weight::from_parts(30_759_000, 0)
// Minimum execution time: 30_530_000 picoseconds.
Weight::from_parts(31_486_000, 0)
.saturating_add(Weight::from_parts(0, 3854))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(1))
Expand All @@ -111,11 +111,11 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `294 + n * (64 ±0)`
// Estimated: `3854`
// Minimum execution time: 18_885_000 picoseconds.
Weight::from_parts(20_249_912, 0)
// Minimum execution time: 18_251_000 picoseconds.
Weight::from_parts(19_651_450, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 5_800
.saturating_add(Weight::from_parts(210_391, 0).saturating_mul(n.into()))
// Standard Error: 6_293
.saturating_add(Weight::from_parts(198_899, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -130,11 +130,11 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `326 + n * (64 ±0)`
// Estimated: `3854`
// Minimum execution time: 24_247_000 picoseconds.
Weight::from_parts(25_414_474, 0)
// Minimum execution time: 23_115_000 picoseconds.
Weight::from_parts(24_416_426, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 6_515
.saturating_add(Weight::from_parts(114_119, 0).saturating_mul(n.into()))
// Standard Error: 6_665
.saturating_add(Weight::from_parts(137_537, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(3))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -147,11 +147,11 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `447 + n * (32 ±0)`
// Estimated: `3854`
// Minimum execution time: 36_883_000 picoseconds.
Weight::from_parts(38_625_795, 0)
// Minimum execution time: 34_887_000 picoseconds.
Weight::from_parts(36_807_788, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 7_342
.saturating_add(Weight::from_parts(120_120, 0).saturating_mul(n.into()))
// Standard Error: 8_126
.saturating_add(Weight::from_parts(138_499, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(2))
}
Expand All @@ -164,11 +164,11 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `204 + n * (32 ±0)`
// Estimated: `3854`
// Minimum execution time: 29_533_000 picoseconds.
Weight::from_parts(30_792_837, 0)
// Minimum execution time: 28_405_000 picoseconds.
Weight::from_parts(29_582_187, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 6_233
.saturating_add(Weight::from_parts(171_872, 0).saturating_mul(n.into()))
// Standard Error: 7_737
.saturating_add(Weight::from_parts(185_990, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -178,10 +178,27 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `215`
// Estimated: `3545`
// Minimum execution time: 12_589_000 picoseconds.
Weight::from_parts(12_971_000, 0)
// Minimum execution time: 11_495_000 picoseconds.
Weight::from_parts(12_441_000, 0)
.saturating_add(Weight::from_parts(0, 3545))
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(1))
}
/// Storage: `Recovery::Recoverable` (r:1 w:1)
/// Proof: `Recovery::Recoverable` (`max_values`: None, `max_size`: Some(351), added: 2826, mode: `MaxEncodedLen`)
/// Storage: `Recovery::ActiveRecoveries` (r:1 w:1)
/// Proof: `Recovery::ActiveRecoveries` (`max_values`: None, `max_size`: Some(389), added: 2864, mode: `MaxEncodedLen`)
/// The range of component `n` is `[1, 9]`.
fn poke_deposit(n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `940`
// Estimated: `3854`
// Minimum execution time: 44_284_000 picoseconds.
Weight::from_parts(47_047_146, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 13_466
.saturating_add(Weight::from_parts(135_039, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(2))
}
}
91 changes: 53 additions & 38 deletions polkadot/runtime/westend/src/weights/pallet_recovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
//! Autogenerated weights for `pallet_recovery`
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 32.0.0
//! DATE: 2025-02-22, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2025-04-16, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! WORST CASE MAP SIZE: `1000000`
//! HOSTNAME: `3a2e9ae8a8f5`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! HOSTNAME: `25e4b24639fd`, CPU: `Intel(R) Xeon(R) CPU @ 2.60GHz`
//! WASM-EXECUTION: `Compiled`, CHAIN: `None`, DB CACHE: 1024

// Executed Command:
Expand Down Expand Up @@ -55,10 +55,10 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// Proof: `Recovery::Proxy` (`max_values`: None, `max_size`: Some(80), added: 2555, mode: `MaxEncodedLen`)
fn as_recovered() -> Weight {
// Proof Size summary in bytes:
// Measured: `182`
// Measured: `215`
// Estimated: `3545`
// Minimum execution time: 13_838_000 picoseconds.
Weight::from_parts(14_446_000, 0)
// Minimum execution time: 11_954_000 picoseconds.
Weight::from_parts(12_547_000, 0)
.saturating_add(Weight::from_parts(0, 3545))
.saturating_add(T::DbWeight::get().reads(1))
}
Expand All @@ -68,8 +68,8 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
// Proof Size summary in bytes:
// Measured: `0`
// Estimated: `0`
// Minimum execution time: 7_795_000 picoseconds.
Weight::from_parts(8_019_000, 0)
// Minimum execution time: 7_109_000 picoseconds.
Weight::from_parts(7_648_000, 0)
.saturating_add(Weight::from_parts(0, 0))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -78,13 +78,13 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// The range of component `n` is `[1, 9]`.
fn create_recovery(n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `76`
// Measured: `109`
// Estimated: `3816`
// Minimum execution time: 28_263_000 picoseconds.
Weight::from_parts(29_693_842, 0)
// Minimum execution time: 26_034_000 picoseconds.
Weight::from_parts(27_220_390, 0)
.saturating_add(Weight::from_parts(0, 3816))
// Standard Error: 6_528
.saturating_add(Weight::from_parts(122_020, 0).saturating_mul(n.into()))
// Standard Error: 6_731
.saturating_add(Weight::from_parts(146_346, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -94,10 +94,10 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// Proof: `Recovery::ActiveRecoveries` (`max_values`: None, `max_size`: Some(389), added: 2864, mode: `MaxEncodedLen`)
fn initiate_recovery() -> Weight {
// Proof Size summary in bytes:
// Measured: `173`
// Measured: `206`
// Estimated: `3854`
// Minimum execution time: 33_442_000 picoseconds.
Weight::from_parts(35_142_000, 0)
// Minimum execution time: 32_191_000 picoseconds.
Weight::from_parts(33_592_000, 0)
.saturating_add(Weight::from_parts(0, 3854))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(1))
Expand All @@ -109,13 +109,13 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// The range of component `n` is `[1, 9]`.
fn vouch_recovery(n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `261 + n * (64 ±0)`
// Measured: `294 + n * (64 ±0)`
// Estimated: `3854`
// Minimum execution time: 22_866_000 picoseconds.
Weight::from_parts(23_906_291, 0)
// Minimum execution time: 20_352_000 picoseconds.
Weight::from_parts(21_589_920, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 4_647
.saturating_add(Weight::from_parts(182_215, 0).saturating_mul(n.into()))
// Standard Error: 6_628
.saturating_add(Weight::from_parts(208_585, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -128,13 +128,13 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// The range of component `n` is `[1, 9]`.
fn claim_recovery(n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `293 + n * (64 ±0)`
// Measured: `326 + n * (64 ±0)`
// Estimated: `3854`
// Minimum execution time: 27_549_000 picoseconds.
Weight::from_parts(28_695_066, 0)
// Minimum execution time: 24_925_000 picoseconds.
Weight::from_parts(26_363_501, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 6_024
.saturating_add(Weight::from_parts(122_957, 0).saturating_mul(n.into()))
// Standard Error: 6_037
.saturating_add(Weight::from_parts(146_777, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(3))
.saturating_add(T::DbWeight::get().writes(1))
}
Expand All @@ -145,13 +145,13 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// The range of component `n` is `[1, 9]`.
fn close_recovery(n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `414 + n * (32 ±0)`
// Measured: `447 + n * (32 ±0)`
// Estimated: `3854`
// Minimum execution time: 38_880_000 picoseconds.
Weight::from_parts(40_901_189, 0)
// Minimum execution time: 36_350_000 picoseconds.
Weight::from_parts(38_023_695, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 8_408
.saturating_add(Weight::from_parts(130_066, 0).saturating_mul(n.into()))
// Standard Error: 9_319
.saturating_add(Weight::from_parts(150_874, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(2))
}
Expand All @@ -162,26 +162,41 @@ impl<T: frame_system::Config> pallet_recovery::WeightInfo for WeightInfo<T> {
/// The range of component `n` is `[1, 9]`.
fn remove_recovery(n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `170 + n * (32 ±0)`
// Measured: `204 + n * (32 ±0)`
// Estimated: `3854`
// Minimum execution time: 32_722_000 picoseconds.
Weight::from_parts(34_426_673, 0)
// Minimum execution time: 29_821_000 picoseconds.
Weight::from_parts(31_401_378, 0)
.saturating_add(Weight::from_parts(0, 3854))
// Standard Error: 7_747
.saturating_add(Weight::from_parts(63_348, 0).saturating_mul(n.into()))
// Standard Error: 8_114
.saturating_add(Weight::from_parts(171_366, 0).saturating_mul(n.into()))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(1))
}
/// Storage: `Recovery::Proxy` (r:1 w:1)
/// Proof: `Recovery::Proxy` (`max_values`: None, `max_size`: Some(80), added: 2555, mode: `MaxEncodedLen`)
fn cancel_recovered() -> Weight {
// Proof Size summary in bytes:
// Measured: `182`
// Measured: `215`
// Estimated: `3545`
// Minimum execution time: 15_521_000 picoseconds.
Weight::from_parts(15_984_000, 0)
// Minimum execution time: 14_010_000 picoseconds.
Weight::from_parts(14_414_000, 0)
.saturating_add(Weight::from_parts(0, 3545))
.saturating_add(T::DbWeight::get().reads(1))
.saturating_add(T::DbWeight::get().writes(1))
}
/// Storage: `Recovery::Recoverable` (r:1 w:1)
/// Proof: `Recovery::Recoverable` (`max_values`: None, `max_size`: Some(351), added: 2826, mode: `MaxEncodedLen`)
/// Storage: `Recovery::ActiveRecoveries` (r:1 w:1)
/// Proof: `Recovery::ActiveRecoveries` (`max_values`: None, `max_size`: Some(389), added: 2864, mode: `MaxEncodedLen`)
/// The range of component `n` is `[1, 9]`.
fn poke_deposit(_n: u32, ) -> Weight {
// Proof Size summary in bytes:
// Measured: `940`
// Estimated: `3854`
// Minimum execution time: 46_038_000 picoseconds.
Weight::from_parts(48_762_984, 0)
.saturating_add(Weight::from_parts(0, 3854))
.saturating_add(T::DbWeight::get().reads(2))
.saturating_add(T::DbWeight::get().writes(2))
}
}
11 changes: 11 additions & 0 deletions prdoc/pr_7882.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
title: add poke_deposit extrinsic to pallet-recovery
doc:
- audience: Runtime Dev
description: This PR adds a new extrinsic `poke_deposit` to `pallet-recovery`. This extrinsic will be used to re-adjust the deposits made in the pallet.
crates:
- name: rococo-runtime
bump: major
Comment thread
UtkarshBhardwaj007 marked this conversation as resolved.
- name: westend-runtime
bump: major
Comment thread
re-gius marked this conversation as resolved.
- name: pallet-recovery
bump: major
Loading