Skip to content

Add event to pure proxy deletion#7995

Merged
rockbmb merged 18 commits into
masterfrom
proxy-pure-fix-event
Apr 29, 2025
Merged

Add event to pure proxy deletion#7995
rockbmb merged 18 commits into
masterfrom
proxy-pure-fix-event

Conversation

@rockbmb
Copy link
Copy Markdown
Contributor

@rockbmb rockbmb commented Mar 21, 2025

Description

The PureCreated event, used in the pure_proxy extrinsic, is used to track the creation of pure proxies.
It now has the extrinsic_index of the pure_proxy call from the block in which it was executed, which is required to kill the pure proxies later.

The pallet_proxy::kill_pure extrinsic now emits an event.

Integration

N/A

Review Notes

N/A

@rockbmb rockbmb added T2-pallets This PR/Issue is related to a particular pallet. T10-tests This PR/Issue is related to tests. T14-system_parachains This PR/Issue is related to system parachains. labels Mar 21, 2025
@rockbmb rockbmb self-assigned this Mar 21, 2025
@rockbmb rockbmb requested a review from a team as a code owner March 21, 2025 17:26
@rockbmb rockbmb force-pushed the proxy-pure-fix-event branch from b6495f8 to 93f89d1 Compare March 21, 2025 17:37
@rockbmb
Copy link
Copy Markdown
Contributor Author

rockbmb commented Mar 21, 2025

@ggwpez since this modifies an already existing Event variant, will this require migrating anything?

Copy link
Copy Markdown
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get the extrinsic index from the EventRecord::Phase already. You don't need to store it here extra.

@rockbmb
Copy link
Copy Markdown
Contributor Author

rockbmb commented Mar 23, 2025

@bkchr thanks for pointing that out; will roll back that change, but still keep the PureKilled event.

Regarding EventRecord::Phase, I would like to update https://support.polkadot.network/support/solutions/articles/65000182196 § "Removing a Pure Proxy".

Just to check: there's no better way to check these data through the PJS dashboard than to use system::events for the block in which proxy.pureProxy was processed, correct?

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Mar 24, 2025

Regarding EventRecord::Phase, I would like to update https://support.polkadot.network/support/solutions/articles/65000182196 § "Removing a Pure Proxy".

In the tutorial they are also subscan. Generally this is quite horrible and should not use PJS. However, I'm not sure if there already exists a dedicated proxy UI (probably mainly around multisigs right now).

@rockbmb
Copy link
Copy Markdown
Contributor Author

rockbmb commented Mar 25, 2025

Regarding EventRecord::Phase, I would like to update https://support.polkadot.network/support/solutions/articles/65000182196 § "Removing a Pure Proxy".

In the tutorial they are also subscan. Generally this is quite horrible and should not use PJS. However, I'm not sure if there already exists a dedicated proxy UI (probably mainly around multisigs right now).

In the tutorial they are also subscan. Generally this is quite horrible and should not use PJS.

Did you mean that they shouldn't be using both Subscan and PJS for this task?

@paritytech-review-bot paritytech-review-bot Bot requested a review from a team March 25, 2025 01:59
@rockbmb rockbmb changed the title Add extra field to pure proxy creation event Add event to pure proxy deletion Mar 25, 2025
Comment thread substrate/frame/proxy/src/lib.rs Outdated
@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/14528387849
Failed job name: test-linux-stable

@rockbmb rockbmb requested a review from ggwpez April 20, 2025 03:37
Comment thread substrate/frame/proxy/src/lib.rs
@rockbmb rockbmb added this pull request to the merge queue Apr 28, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 29, 2025
@rockbmb rockbmb enabled auto-merge April 29, 2025 00:40
@rockbmb rockbmb added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit 4da143e Apr 29, 2025
242 of 250 checks passed
@rockbmb rockbmb deleted the proxy-pure-fix-event branch April 29, 2025 01:41
castillax pushed a commit that referenced this pull request May 12, 2025
# Description

~~The `PureCreated` event, used in the `pure_proxy` extrinsic, is used
to track the creation of pure proxies.
It now has the `extrinsic_index` of the `pure_proxy` call from the block
in which it was executed, which is required to kill the pure proxies
later.~~

The `pallet_proxy::kill_pure` extrinsic now emits an event.

## Integration

N/A

## Review Notes

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet. T10-tests This PR/Issue is related to tests. T14-system_parachains This PR/Issue is related to system parachains.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants