rewrite systematic chunk recovery test with zombienet-sdk#8553
Closed
alindima wants to merge 1 commit into
Closed
Conversation
alindima
added
T8-polkadot
Closed
24 tasks
alvicsam
approved these changes
May 16, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
sandreim
reviewed
May 16, 2025
| })) | ||
| .with_collator(|n| n.with_name("collator-2000")) | ||
| }) | ||
| .with_parachain(|p| { |
Contributor
There was a problem hiding this comment.
seems copy paste from above, dedup ?
| type MaxAuthorities = ConstU32<100_000>; | ||
| type AllowMultipleBlocksPerSlot = ConstBool<true>; | ||
| type SlotDuration = ConstU64<2000>; | ||
| type SlotDuration = ConstU64<SLOT_DURATION>; |
Contributor
There was a problem hiding this comment.
I don't understand why we need to make this change. Why not run it with the slot based collator ?
Should do 6s blocks just fine as is.
github-project-automation
Bot
moved this from Backlog
to Completed
in parachains team board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite systematic chunk recovery test with zombienet-sdk.
Also switches glutton-westend back to 6-second block time, which is why this test must have been failing sometimes (since it had a 2-second slot but wasn't using the slot-based collator). This was changed by me in #5372 (probably for some versi testing and I later forgot to remove it)