Skip to content

Parachains runtime: properly filter backed candidate votes#9564

Merged
EgorPopelyaev merged 6 commits into
masterfrom
sandreim/drop_right_vote
Aug 27, 2025
Merged

Parachains runtime: properly filter backed candidate votes#9564
EgorPopelyaev merged 6 commits into
masterfrom
sandreim/drop_right_vote

Conversation

@sandreim
Copy link
Copy Markdown
Contributor

@sandreim sandreim commented Aug 27, 2025 •
edited
Loading

The filter_backed_statements_from_disabled_validators function does not properly map indices in the validator group to indices in the validity votes vec. This PR fixes that.

TODO:

  • add more tests
  • PRDoc

@sandreim
map index
1a61b4f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
eskimor
eskimor reviewed Aug 27, 2025
View reviewed changes
Comment thread polkadot/runtime/parachains/src/paras_inherent/mod.rs
@sandreim
Add one more test
ea1f1f8 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim marked this pull request as ready for review August 27, 2025 14:50
@sandreim sandreim requested a review from tdimitrov August 27, 2025 14:52
tdimitrov
tdimitrov reviewed Aug 27, 2025
View reviewed changes
Comment thread polkadot/runtime/parachains/src/paras_inherent/mod.rs
@paritytech-workflow-stopper
Copy link
Copy Markdown

paritytech-workflow-stopper Bot commented Aug 27, 2025

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/17270302766
Failed job name: test-linux-stable

@sandreim
Copy link
Copy Markdown
Contributor Author

sandreim commented Aug 27, 2025

/cmd prdoc generate --bump patch

sandreim and others added 4 commits August 27, 2025 19:26
@sandreim
fix test
259c9a8 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@github-actions
Update from github-actions[bot] running command 'prdoc generate --bum…
cee9652 
…p patch'
@sandreim
prdoc
23c8ca1 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' into sandreim/drop_right_vote
c81c9ac
@sandreim sandreim added T8-polkadot This PR/Issue is related to/affects the Polkadot network. A4-backport-stable2503 A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch labels Aug 27, 2025
eskimor
eskimor approved these changes Aug 27, 2025
View reviewed changes
Comment thread polkadot/runtime/parachains/src/paras_inherent/tests.rs
@sandreim sandreim mentioned this pull request Aug 27, 2025
Open
@sandreim sandreim enabled auto-merge August 27, 2025 18:24
@EgorPopelyaev EgorPopelyaev disabled auto-merge August 27, 2025 19:49
@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue Aug 27, 2025
Merged via the queue into master with commit 3dfbdf4 Aug 27, 2025
284 of 292 checks passed
@EgorPopelyaev EgorPopelyaev deleted the sandreim/drop_right_vote branch August 27, 2025 20:28
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Aug 27, 2025
@sandreim @github-actions
Parachains runtime: properly filter backed candidate votes (#9564)
36e3684 
The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO:
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3dfbdf4)
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot Bot commented Aug 27, 2025

Successfully created backport PR for stable2503:

@paritytech-release-backport-bot paritytech-release-backport-bot Bot mentioned this pull request Aug 27, 2025
Merged
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Aug 27, 2025
@sandreim @github-actions
Parachains runtime: properly filter backed candidate votes (#9564)
f3d2bc8 
The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO:
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3dfbdf4)
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot Bot commented Aug 27, 2025

Successfully created backport PR for stable2506:

@paritytech-release-backport-bot paritytech-release-backport-bot Bot mentioned this pull request Aug 27, 2025
Merged
paritytech-release-backport-bot Bot pushed a commit that referenced this pull request Aug 27, 2025
@sandreim @github-actions
Parachains runtime: properly filter backed candidate votes (#9564)
53cf109 
The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO:
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 3dfbdf4)
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot Bot commented Aug 27, 2025

Successfully created backport PR for unstable2507:

@paritytech-release-backport-bot paritytech-release-backport-bot Bot mentioned this pull request Aug 27, 2025
Merged
sandreim added a commit that referenced this pull request Aug 28, 2025
@paritytech-release-backport-bot @sandreim @github-actions
[unstable2507] Backport #9564 (#9584)
b99cdb8 
Backport #9564 into `unstable2507` from sandreim.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
EgorPopelyaev pushed a commit that referenced this pull request Aug 28, 2025
@paritytech-release-backport-bot @sandreim @github-actions
[stable2503] Backport #9564 (#9582)
00642f4 
Backport #9564 into `stable2503` from sandreim.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Aug 28, 2025
Merged
Merged
fellowship-merge-bot Bot pushed a commit to polkadot-fellows/runtimes that referenced this pull request Aug 28, 2025
@sandreim
Release 1.7.1 (#870)
18cbc8b 
Release runtimes 1.7.1:
- Bump `polkadot-runtime-parachains` to 21.0.1 (includes
[#9564](paritytech/polkadot-sdk#9564))
- Updated CHANGELOG
- Bumped runtime spec versions to `1_007_001`

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
fellowship-merge-bot Bot pushed a commit to polkadot-fellows/runtimes that referenced this pull request Aug 29, 2025
@sandreim @acatangiu
Release 1.6.2 (Polkadot only) (#871)
33ffc09 
This is release targeting only the Polkadot RC, so I am not bumping spec
versions for anything else.

Changes:
- Bump `polkadot-runtime-parachains` to 19.2.1 (includes
[#9564](paritytech/polkadot-sdk#9564))
- Updated CHANGELOG
- Bumped Polkadot RC runtime spec versions to `1_006_002`

I've also checked the diff of PRs since Polkdot-SDK `2503-7-rc1` @
[b9ac350](paritytech/polkadot-sdk@b9ac350)
relevant to the minor/patch bumps for dependencies of
`polkadot-runtime-parachains v19.2.1`:
- frame-benchmarking v40.2.0 -> v40.2.1 
- frame-system v40.1.0 -> v40.2.0
- pallet-balances v41.1.0 -> v41.1.1
- staging-xcm-executor v19.1.2 -> v19.1.3 

There is no need to do any further changes (weights, migrations, etc)
for this Polkadot RC release, but please review and double check.

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
EgorPopelyaev added a commit that referenced this pull request Sep 2, 2025
@paritytech-release-backport-bot @sandreim
@github-actions @EgorPopelyaev
[stable2506] Backport #9564 (#9583)
ed54223 
Backport #9564 into `stable2506` from sandreim.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <egor@parity.io>
@Polkadot-Forum
Copy link
Copy Markdown

Polkadot-Forum commented Sep 3, 2025

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/2025-08-24-kusama-stall-postmortem/14729/1

@sandreim sandreim mentioned this pull request Sep 3, 2025
Closed
ParthDesai pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Sep 3, 2025
@sandreim @github-actions @ParthDesai
Parachains runtime: properly filter backed candidate votes (paritytec…
464bbbc 
…h#9564)

The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO: 
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ParthDesai added a commit to moondance-labs/polkadot-sdk that referenced this pull request Sep 3, 2025
@ParthDesai @sandreim @github-actions
Parachains runtime: properly filter backed candidate votes (paritytec…
70be099 
…h#9564) (#13)

The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO: 
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ParthDesai pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Sep 8, 2025
@sandreim @github-actions @ParthDesai
Parachains runtime: properly filter backed candidate votes (paritytec…
d78fcad 
…h#9564)

The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO: 
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ParthDesai ParthDesai mentioned this pull request Sep 8, 2025
Merged
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
@sandreim @github-actions @alvicsam
Parachains runtime: properly filter backed candidate votes (#9564)
7ce80d8 
The `filter_backed_statements_from_disabled_validators` function does
not properly map indices in the validator group to indices in the
validity votes vec. This PR fixes that.

TODO: 
- [x] add more tests
- [x] PRDoc

---------

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdimitrov tdimitrov tdimitrov approved these changes

@eskimor eskimor eskimor approved these changes

@alexggh alexggh alexggh approved these changes

Assignees

No one assigned

Labels

A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-unstable2507 Pull request must be backported to the unstable2507 release branch T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sandreim @Polkadot-Forum @tdimitrov @eskimor @alexggh @pgherveou @EgorPopelyaev