Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Runtime: Kusama gets Society v2#7356

Merged
gavofyork merged 15 commits into
masterfrom
gav-society-v2
Jun 18, 2023
Merged

Runtime: Kusama gets Society v2#7356
gavofyork merged 15 commits into
masterfrom
gav-society-v2

Conversation

@gavofyork
Copy link
Copy Markdown
Member

@gavofyork gavofyork commented Jun 12, 2023 •
edited
Loading

TODO

  • Introduce migration.
  • Introduce correct data for migration.

Later:

  • Test migration with try_runtime.

@paritytech-ci paritytech-ci requested review from a team June 12, 2023 17:09
@gavofyork gavofyork added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 12, 2023
@gavofyork gavofyork mentioned this pull request Jun 12, 2023
Merged
7 tasks
kianenigma
kianenigma approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; as for testing, this is possibly a good candidate to be tested with Chopsticks, as it should allow you to even test the new UI, if it has already been catered for.

liamaharon
liamaharon approved these changes Jun 15, 2023
View reviewed changes
Comment thread Cargo.toml Outdated
@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Jun 18, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3017820

@paritytech-ci paritytech-ci requested a review from a team June 18, 2023 14:39
bkchr
bkchr approved these changes Jun 18, 2023
View reviewed changes
Comment thread runtime/kusama/src/past_payouts.rs
}

#[test]
fn check_addresses() {
Copy link
Copy Markdown
Member

@bkchr bkchr Jun 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is not really testing anything and just prints the information.

Copy link
Copy Markdown
Member Author

@gavofyork gavofyork Jun 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed; it's to help people check that the addresses are correct since history is determinable through ss58 addresses only.

Comment thread runtime/rococo/src/lib.rs Outdated
@ggwpez ggwpez added the E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. label Jun 18, 2023
ggwpez
ggwpez approved these changes Jun 18, 2023
View reviewed changes
Comment thread runtime/kusama/src/past_payouts.rs
Comment thread runtime/rococo/src/lib.rs
@gavofyork gavofyork enabled auto-merge (squash) June 18, 2023 16:23
@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Jun 18, 2023

Later:

  • Test migration with try_runtime.

Westend and Kusama should go green in the CI. Polkadot not until https://polkadot.polkassembly.io/referenda/9 (just a failing assertion - the upgrade itself still works).

@gavofyork gavofyork merged commit 47c8c36 into master Jun 18, 2023
@gavofyork gavofyork deleted the gav-society-v2 branch June 18, 2023 16:54
@kianenigma
Copy link
Copy Markdown
Contributor

kianenigma commented Jun 20, 2023

Later:

  • Test migration with try_runtime.

Westend and Kusama should go green in the CI. Polkadot not until https://polkadot.polkassembly.io/referenda/9 (just a failing assertion - the upgrade itself still works).

Looking at the last kusama migration CI job, I am not sure if the migration was properly tested. The errors are properly coming from the earlier items in type Migrations and it is not reaching Unreleased at all.

@liamaharon
Copy link
Copy Markdown
Contributor

liamaharon commented Jun 20, 2023

Later:

  • Test migration with try_runtime.

Westend and Kusama should go green in the CI. Polkadot not until https://polkadot.polkassembly.io/referenda/9 (just a failing assertion - the upgrade itself still works).

Looking at the last kusama migration CI job, I am not sure if the migration was properly tested. The errors are properly coming from the earlier items in type Migrations and it is not reaching Unreleased at all.

I'm taking a look at this.

@liamaharon
Copy link
Copy Markdown
Contributor

liamaharon commented Jun 20, 2023 •
edited
Loading

Kusama on-runtime-upgrade fix PRs

@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@anaelleparity anaelleparity mentioned this pull request Nov 8, 2023
Closed
10 tasks
@laboon laboon mentioned this pull request Dec 18, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@liamaharon liamaharon liamaharon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

Runtime / FRAME
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gavofyork @paritytech-cicd-pr @ggwpez @kianenigma @liamaharon @sam0x17 @bkchr