This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Clear Existing HRMP Channel Request When Force Opening#7389
Merged
paritytech-processbot[bot] merged 5 commits intoJun 21, 2023
Conversation
joepetrowski
added
A0-please_review
bkchr
approved these changes
Jun 17, 2023
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
100% correct solution would work with weight refunding, but not sure it is wort the complexity given that this is not called that often.
bkchr
approved these changes
Jun 19, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
ggwpez
reviewed
Jun 21, 2023
ggwpez
approved these changes
Jun 21, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Contributor
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite often a parachain makes a channel request to a system parachain, followed by a governance proposal that fails because the request already exists. Since we are using "force", this removes the common error case by clearing an existing request.