feat: add LLVM as git submodule #346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced changes ------------------ - Replaced revive-llvm clone with git submodule approach. - Pin LLVM to commit 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff (llvmorg-18.1.8). - Updated Makefile to use 'git submodule update --init --recursive'. - Modified .gitignore to allow llvm submodule directory. - Removed LLVM.lock file and lock mechanism from llvm-builder. - Replaced clone/checkout commands with submodule initialization. - Updated CI workflows to use submodules: true in checkout actions. - Simplified revive-llvm CLI to build/clean/builtins commands only. Closes issue paritytech#306 * refact: cleaned up dependencies and tests in llvm-builder Introduced changes ------------------ - Removed `serde` and `toml` dependencies from `Cargo.toml` and `Cargo.lock`. - Simplified test functions by renaming and removing unnecessary clone commands. - Updated `TestDir` to initialize a temporary directory with submodule setup instead of using a lockfile. - Deleted outdated tests related to cloning and checking out branches since they are no longer needed. Signed-off-by: 0xf333 <[email protected]>
xermicus
reviewed
Jun 19, 2025
There was a problem hiding this comment.
Many thanks! I'd like to see whether the LLVM release works properly with those changes. Would you mind to either try it in a fork of yours or open the PR against https://github.com/paritytech/revive-alex-workflowtest/tree/main ?
I tested it, It's working with the latest llvm. Check the branch in my repo fork: https://github.com/0xf333/revive/tree/pr-346-with-llvm-20.1.7 |
|
Ah so what I'd like to see is a LLVM release to verify whether the GHA works (using LLVM 18.1.8 - we can't update just yet). |
Since the workflow already uses 'actions/checkout@v4' with 'submodules: true', the LLVM submodule is automatically checked out at the pinned commit, making the separate clone step unnecessary and broken. Signed-off-by: 0xf333 <[email protected]>
0xf333
force-pushed
the
feat-added-llvm-as-a-git-submodule
branch
from
eb78b42 to
4444ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced changes
3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff (llvmorg-18.1.8)..gitignoreto allow llvm submodule directory.LLVM.lockfile and lock mechanism from llvm-builder.clone/checkoutcommands with submodule initialization.CIworkflows to use submodules:truein checkout actions.revive-llvmCLI to build/clean/builtins commands only.Closes issue #306