This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Possible state inconsistency between Notifications
and ProtocolController
when incoming connection is dropped #14225
Closed
Description
There is a comment in Notifications
behavior while handling ConnectionClosed
event:
substrate/client/network/src/protocol/notifications/behaviour.rs
Lines 1238 to 1239 in 79d37ef
This is likely incorrect behavior, because if we had already sent an "incoming" request to ProtocolController
(aka "peerset") and it answered with "accept", it would be thinking that we are connected to this peer, while in reality the connection was dropped.
Metadata
Metadata
Assignees
Type
Projects
Status
Done ✅