Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Possible state inconsistency between Notifications and ProtocolController when incoming connection is dropped #14225

Closed
@dmitry-markin

Description

@dmitry-markin

There is a comment in Notifications behavior while handling ConnectionClosed event:

// In the incoming state, we don't report "Dropped". Instead we will
// just ignore the corresponding Accept/Reject.

This is likely incorrect behavior, because if we had already sent an "incoming" request to ProtocolController (aka "peerset") and it answered with "accept", it would be thinking that we are connected to this peer, while in reality the connection was dropped.

Metadata

Metadata

Assignees

No one assigned

    Labels

    I6-documentationDocumentation needs fixing, improving or augmenting.U2-some_time_soonIssue is worth doing soon.

    Type

    No type

    Projects

    Status

    Done ✅

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions