Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Refactor BlockBuilder::propose_with#14405

Merged
paritytech-processbot[bot] merged 8 commits into
masterfrom
oty-refactor-block-builder
Jun 19, 2023
Merged

Refactor BlockBuilder::propose_with#14405
paritytech-processbot[bot] merged 8 commits into
masterfrom
oty-refactor-block-builder

Conversation

@ggwpez

@ggwpez ggwpez commented Jun 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Non-controversial refactoring of the BlockBuilder to make #14275 easier to review.

Changes:

  • Splits the code of propose_with into apply_inherents, apply_extrinsicis and print_summary.
  • Prints no extrinsics instead of extrinsics (0): [] when there are none.
  • Adds log level.

ggwpez added 6 commits June 16, 2023 13:22
@ggwpez
Add log target
7435788 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Factor out apply_inherents
6b1d6b1 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Factor out apply_extrinsics
0b7dddc 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Factor out print_summary
648e005 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Pimp print_summary
24c8bf6 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Cleanup
4b99c6e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 16, 2023
@ggwpez
Fixes
93f0d32 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from a team June 17, 2023 14:50
melekes
melekes approved these changes Jun 18, 2023
View reviewed changes

@melekes melekes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bkchr
bkchr approved these changes Jun 19, 2023
View reviewed changes
Comment thread client/basic-authorship/src/basic_authorship.rs Outdated
Comment thread client/basic-authorship/src/basic_authorship.rs
@ggwpez @bkchr
Update client/basic-authorship/src/basic_authorship.rs
a0cf3a9 
Co-authored-by: Bastian Köcher <git@kchr.de>
@ggwpez

ggwpez commented Jun 19, 2023

Copy link
Copy Markdown
Member Author

bot merge

@paritytech-processbot

paritytech-processbot Bot commented Jun 19, 2023

Copy link
Copy Markdown

Waiting for commit status.

@paritytech-processbot paritytech-processbot Bot merged commit 2e7fde8 into master Jun 19, 2023
@paritytech-processbot paritytech-processbot Bot deleted the oty-refactor-block-builder branch June 19, 2023 10:12
@ggwpez ggwpez mentioned this pull request Jun 20, 2023
Draft
2 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@ggwpez @bkchr @nathanwhit
Refactor BlockBuilder::propose_with (paritytech#14405)
bb67be7 
* Add log target

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Factor out apply_inherents

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Factor out apply_extrinsics

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Factor out print_summary

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Pimp print_summary

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Cleanup

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update client/basic-authorship/src/basic_authorship.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
@ggwpez ggwpez mentioned this pull request Oct 3, 2023
Merged
4 tasks
@ukint-vs ukint-vs mentioned this pull request May 1, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@gavofyork gavofyork gavofyork approved these changes

@melekes melekes melekes approved these changes

@skunert skunert skunert approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggwpez @gavofyork @melekes @skunert @bkchr