This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Key generation utility #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why call it ss58Check and not base58Check or base58Blake2b. What does "ss" stand for? Also bitcoin base58Check hashes twice, though I'm not sure if that's important here. |
|
Can't see why two hashes would be important. "ss58check address" -> substrate base58 checksum address (and as a name, it's already in use in at least two other projects). |
arkpar
approved these changes
May 29, 2018
arkpar
added
A8-looksgood
and removed
A0-please_review
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* Update to master This introduces a new type `CollatorId`, currently just `SessionKey` but which would forseeably change to its own thing. It seems to work like this (despite there being a lot of the new-incompatible `AccountId` replaced). No idea if it does anything sensible, though. * Cleanups * Fix tests * Remove commented code * Specify commit hash * Remove commented code * Correct version * Update runtime/Cargo.toml Co-Authored-By: gavofyork <[email protected]> * PairT instead of _Pair * Update lock file * Remove rev causing upset
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* Update substrate -> c9d9365 (master) * Update frontier -> 7e6f52e (v0.5-hotfixes) * Update Cumulus and re-resolve some dependency versions * Use same polkadot commit as Cumulus * Resolve dependencies related to primitive-types * Add SS58Prefix chain id to runtime config * Implement query_fee_details from TransactionPayment trait * Ensure frontier always points to v0.5-hotfixes * Let cargo update Cargo.lock * Move pubsub and rpc "hotfixes" back to frontier * Update cumulus and polkadot * correct hotfixes branch * Made it to compile errors in actual moonbeam code :) * runtime compiles * new logger structure * Fix call to start_collator * Totally not-dubious changes to Cargo.lock * Impl new query_fee_details fn * Revert "Impl new query_fee_details fn" This reverts commit 8c943f7279a9a6a3f453eb9e16beba3c501bd62b. * Update rpc and standalone to use txn graph * Cargo.lock changes again * Add graph to FullDeps @ parachain service * Run cargo fmt * Appease editorconfig * add web3api server * Spawn background task for pending transactions * Add log subscription tests * Add pending transaction RPC test * Prefer spaces over tabs in typescript tests * s/describeWithFrontier/describeWithMoonbeam/ * Post-merge clean up * prettier * rustfmt * fix test formatting * Fixes tests for pallet stake * Update runtime/Cargo.toml Co-authored-by: Joshy Orndorff <[email protected]> * reapply de-alias * restore missing cargo dep * Fixes new tests * Fixes some tests * Fix test-pending-pool * Fix test-subscription * Update Cargo.lock * Improves polkadot api test (WIP) * Better polkadot tests Co-authored-by: Joshy Orndorff <[email protected]> Co-authored-by: crystalin <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]> Co-authored-by: Crystalin <[email protected]> Co-authored-by: tgmichel <[email protected]>
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* bug fix for fee
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* let to_base58 accept bytes ref * let BtcAddress be Vec<u8> * refactor addrbinding * integrate staking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes in after #175