Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update primitive-types crate #4866

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Update primitive-types crate #4866

merged 1 commit into from
Feb 10, 2020

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Feb 9, 2020

- ancient rand dependency

@NikVolf NikVolf added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Feb 9, 2020
@NikVolf NikVolf requested a review from sorpaas as a code owner February 9, 2020 15:27
@NikVolf NikVolf force-pushed the nv-update-primitive-types branch from 8426af6 to a20f461 Compare February 9, 2020 15:29
@NikVolf NikVolf added the B0-silent Changes should not be mentioned in any release notes label Feb 9, 2020
@NikVolf NikVolf requested a review from bkchr February 9, 2020 15:50
@NikVolf NikVolf added A4-gotissues and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Feb 9, 2020
@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 9, 2020

Actually, it seems that it gives like ~5% performance hit during block import
Probably due to paritytech/parity-common#317

And primitive-types/libc feature is explicitly used in sp-core

@ordian ^^^

@NikVolf NikVolf removed the request for review from bkchr February 9, 2020 16:06
@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 9, 2020

with primitive-types/libc

import block/Wasm       time:   [4.5876 s 4.6357 s 4.7006 s]
import block/Native     time:   [2.5677 s 2.6154 s 2.6846 s]  

without primitive-types/libc:

import block/Wasm       time:   [4.7306 s 4.8279 s 4.9466 s]                               
                        change: [+3.1825% +5.5383% +7.6266%] (p = 0.00 < 0.05)
                        Performance has regressed.

import block/Native     time:   [2.7783 s 2.8249 s 2.8624 s]                                 
                        change: [+2.5561% +6.1032% +9.7396%] (p = 0.00 < 0.05)
                        Performance has regressed.

@ordian
Copy link
Member

ordian commented Feb 10, 2020

Actually, it seems that it gives like ~5% performance hit during block import
Probably due to paritytech/parity-common#317

And primitive-types/libc feature is explicitly used in sp-core

@ordian ^^^

I opened rust-lang/rust#69024.

We haven't published a new version of fixed-hash and if you think the libc feature removal should be reverted, we still can do it.

@NikVolf
Copy link
Contributor Author

NikVolf commented Feb 10, 2020

We haven't published a new version of fixed-hash and if you think the libc feature removal should be reverted, we still can do it.

Yeah, the fact that it is not published probably unblocks this pr.
Performance issues still should be addressed though - I've benched against just latest parity-common, but we'll figure out later.

@NikVolf NikVolf added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A4-gotissues labels Feb 10, 2020
@NikVolf NikVolf force-pushed the nv-update-primitive-types branch from a20f461 to 03e5353 Compare February 10, 2020 16:44
@NikVolf NikVolf merged commit 613a3bc into master Feb 10, 2020
@NikVolf NikVolf deleted the nv-update-primitive-types branch February 10, 2020 19:21
sorpaas pushed a commit that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants