This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Minor fixes for Android compilation #5209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A2-insubstantial
tomusdrw
approved these changes
Mar 10, 2020
Contributor
tomusdrw
left a comment
tomusdrw
left a comment
There was a problem hiding this comment.
Looks good, benches fail though.
Contributor
Author
|
I don't understand what my PR has to do with that, but the CI failure has been fixed a couple weeks ago by libp2p/rust-libp2p#1468 and I ran |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 12, 2020
* Minor fixes for Android * Update parity-multiaddr * Bump in service Cargo.toml too
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
* Minor fixes for Android * Update parity-multiaddr * Bump in service Cargo.toml too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor changes that will help build for Android:
hyper-rustlsto pull the new version ofrustls-native-certs.rustls-native-certs v0.1doesn't compile for Android.rocksdbfeature fromsc-servicewhen not necessary.