Remove derive_more from dependencies
#1602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
May 22, 2024
There was a problem hiding this comment.
Would be easier to review if you could omit the TOML fmt changes, I guess you are using some fmt tool for that.
I for one preferred to old format with features on line but perhaps we could add some fmt rules in this repo. Substrate is using taplo for that I guess we could as well
|
We've had this sort of thing before, and yeah I'd be up for having some CI check that the TOML formatting is ok (+ a thing to run to make it ok), just to avoid any disagreements on what the format should be etc once it's set up :) |
jsdw
approved these changes
May 22, 2024
pkhry
force-pushed
the
pkhry/derive_more_display
branch
from
96cbd4b to
98167fd
Compare
pkhry
force-pushed
the
pkhry/remove_derive_more
branch
from
0d2b3c9 to
4bec8e7
Compare
dropped formatting changes until we setup the autoformatting tool |
pkhry
added a commit
that referenced
this pull request
May 22, 2024
pkhry
added a commit
that referenced
this pull request
May 22, 2024
pkhry
added a commit
that referenced
this pull request
May 23, 2024
niklasad1
added a commit
that referenced
this pull request
May 24, 2024
* replace derive_more's 'From' in signer * replace derive_more's 'From' in core * Remove `derive_more`'s `Display` usages (#1601) * Remove derive_more's 'Display' from core * Remove derive_more's 'Display' from metadata * Remove derive_more's 'Display' from signer * Remove derive_more from dependencies (#1602) closes #1503 * Update signer/src/eth.rs Co-authored-by: Niklas Adolfsson <[email protected]> * rename convert_error to impl_from * rename convert_error to impl_from in core --------- Co-authored-by: Niklas Adolfsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1503