Release/1.0.22 #183
Release/1.0.22 #183
Conversation
Fix parse encoder bug.
|
Are these functions missing a call to |
| } | ||
|
|
||
| if (value is ParseFile) { | ||
| return value; | ||
| return value.toJson(); |
There was a problem hiding this comment.
I'm quite concerned with this.
As far as I am aware ParseFile is working? What is this for?
There was a problem hiding this comment.
Hi @phillwiggins
ParseFile it's working.
This line is not necessary because the method toJson () is already called by default.
There was a problem hiding this comment.
ParseGeoPoint too it's woking.
When you call a method encode in a json, toJson () is always triggered. We have Parse objects, and each class already has its toJson method with override, so just put the "value".
There was a problem hiding this comment.
Thanks for confirmation @RodrigoSMarques
@yulingtianxia please can you remove these .toJson() calls. They are unnecessary. Thank you.
There was a problem hiding this comment.
@phillwiggins
Before launching a new release, please contact me so I can do a regression test with my test application, just as we did the other times. Ensure that what is ready is not broken.
There was a problem hiding this comment.
@phillwiggins @RodrigoSMarques Thanks for explanation! Learned a lot.
There was a problem hiding this comment.
@phillwiggins I think I should make another PR in a new branch and close this PR.
Fix encode bug.
Fix LiveQuery Exception.