Skip to content

fix: query fails for subclassed Parse object in Parse relation #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fischerscode
Copy link
Contributor

New Pull Request Checklist

Issue Description

Related issue: #696

Approach

Due to the deletion of the development branch #697 was closed automatically.
I've decided to cherry pick 4829c36 and (re-)open the PR to avoid loosing a contribution.

This change is not tested by me. Since I didn't use relations yet.

CC: @kutear

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #763 (a8f66b9) into master (d80ca58) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   10.28%   10.28%           
=======================================
  Files          48       48           
  Lines        2810     2810           
=======================================
  Hits          289      289           
  Misses       2521     2521           
Impacted Files Coverage Δ
packages/dart/lib/src/objects/parse_relation.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80ca58...a8f66b9. Read the comment docs.

@RodrigoSMarques
Copy link
Contributor

RodrigoSMarques commented Jun 3, 2022

@fischerscode Your PR has not been lost. Here

@fischerscode
Copy link
Contributor Author

Closing this, since it is included in #762.

@fischerscode fischerscode deleted the fix/subclass-relation branch June 3, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants