feat: Add query constraint `wherePolygonContains` to determine whether a point in within a polygon #778

Paul0Cesar · 2022-07-18T17:27:11Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Create a new constraint to check if Polygon contains the geopoint

Closes: #777

Approach

create a new method to add polygon constraint in query

TODOs before merging

Add changes to documentation (guides, repository pages, in-code descriptions)

parse-github-assistant · 2022-07-18T17:27:13Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

mtrezza · 2022-07-20T11:47:28Z

Could you add a test?

mtrezza · 2022-08-18T19:13:18Z

@parse-community/flutter-sdk-review could someone please review this?

packages/dart/test/parse_query_test.dart

codecov · 2022-08-18T19:17:45Z

Codecov Report

Base: 15.13% // Head: 15.83% // Increases project coverage by +0.70% 🎉

Coverage data is based on head (45a7056) compared to base (7f24fb2).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 45a7056 differs from pull request most recent head 4ea2f2c. Consider uploading reports for the commit 4ea2f2c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   15.13%   15.83%   +0.70%     
==========================================
  Files          47       47              
  Lines        2855     2860       +5     
==========================================
+ Hits          432      453      +21     
+ Misses       2423     2407      -16

Impacted Files	Coverage Δ
packages/dart/lib/src/network/parse_query.dart	`22.31% <100.00%> (+1.57%)`	⬆️
packages/dart/lib/src/utils/parse_decoder.dart	`58.49% <0.00%> (+20.75%)`	⬆️
packages/dart/lib/src/objects/parse_geo_point.dart	`45.45% <0.00%> (+45.45%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza

Could you take a look at the failing lint test?

Paul0Cesar · 2022-09-05T13:30:22Z

Could you take a look at the failing lint test?

@mtrezza , sorry for the late answer, I fix the lint error

mtrezza · 2022-09-09T17:34:48Z

Thanks @Paul0Cesar, all tests pass. Let's wait for a review by @parse-community/flutter-sdk-review to merge this.

mtrezza · 2022-11-28T23:11:16Z

@mbfakourii Thanks for reviewing this.

@Paul0Cesar To merge this, could you add the change log entry and bump the version by a minor version number? It seems this is only related to the dart package, so the change log and version number only needs to be changed there.

Paul0Cesar · 2023-01-18T23:54:27Z

@mtrezza , sorry for the late answer, I merge the master branch, fix the constant SINGLE QUERY not using _SINGLE_QUERY, and change the version

mbfakourii

The test must be changed

packages/dart/test/parse_query_test.dart

Paul0Cesar · 2023-01-19T13:46:01Z

@mbfakourii, I change the code formatting, can you check again?

mbfakourii

Thanks for the changes looks good

mtrezza

Minor changelog

packages/dart/CHANGELOG.md

mtrezza

Lint fails, could you take a look?

Paul0Cesar · 2023-01-21T15:47:39Z

@mtrezza , done, can you check? 🚀

packages/dart/test/parse_query_test.dart

packages/dart/CHANGELOG.md

mtrezza

Looks good

Paul0Cesar force-pushed the feauture/add-polygon-constraint branch from d5b05c7 to 5e1641c Compare July 18, 2022 17:31

Paul0Cesar changed the title ~~feature add constraint to polygon~~ feat: add constraint to polygon Jul 18, 2022

mtrezza requested a review from a team July 20, 2022 11:47

feat: add constraint to polygon

d00b8d0

Paul0Cesar force-pushed the feauture/add-polygon-constraint branch from 5e1641c to d00b8d0 Compare July 25, 2022 14:45

mtrezza reviewed Aug 18, 2022

View reviewed changes

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

Update packages/dart/test/parse_query_test.dart

a869cf7

mtrezza reviewed Aug 18, 2022

View reviewed changes

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

Update packages/dart/test/parse_query_test.dart

080cc5c

mtrezza requested changes Aug 18, 2022

View reviewed changes

Update packages/dart/lib/src/network/parse_query.dart

f07cc7b

mtrezza changed the title ~~feat: add constraint to polygon~~ feat: add query constraint wherePolygonContains to determine whether a point in within a polygon Sep 9, 2022

mbfakourii previously approved these changes Nov 28, 2022

View reviewed changes

Merge branch 'master' into feauture/add-polygon-constraint

61c36e4

mtrezza changed the title ~~feat: add query constraint wherePolygonContains to determine whether a point in within a polygon~~ feat: Add query constraint wherePolygonContains to determine whether a point in within a polygon Nov 28, 2022

Paul0Cesar added 3 commits January 18, 2023 20:38

Merge branch 'master' into feauture/add-polygon-constraint

b3f16fc

fix query arg to use new variable _singleQuery

7e6efec

bumped version and add Changes in CHANGELOG.md

cc46b3c

Paul0Cesar dismissed mbfakourii’s stale review via cc46b3c January 18, 2023 23:49

Paul0Cesar requested a review from mtrezza January 18, 2023 23:58

mbfakourii suggested changes Jan 19, 2023

View reviewed changes

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

fix test code formatting of wherePolygonContains

5fbf5d0

Paul0Cesar requested review from mbfakourii and removed request for mtrezza January 19, 2023 13:44

mbfakourii previously approved these changes Jan 19, 2023

View reviewed changes

mbfakourii requested a review from mtrezza January 19, 2023 13:52

mtrezza previously approved these changes Jan 20, 2023

View reviewed changes

packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved

packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved

Update packages/dart/CHANGELOG.md

a133078

mtrezza dismissed stale reviews from mbfakourii and themself via a133078 January 20, 2023 15:25

Update packages/dart/CHANGELOG.md

715da66

mtrezza requested changes Jan 20, 2023

View reviewed changes

fix lint in parse_query_test.dart

0203d97

mtrezza requested changes Jan 21, 2023

View reviewed changes

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

packages/dart/test/parse_query_test.dart Outdated Show resolved Hide resolved

mtrezza added 2 commits January 21, 2023 23:17

code style

44e59af

code style

45a7056

mtrezza reviewed Jan 21, 2023

View reviewed changes

packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved

changelog date

4ea2f2c

mtrezza approved these changes Jan 21, 2023

View reviewed changes

mtrezza merged commit 2afa2ad into parse-community:master Jan 21, 2023

Uh oh!

feat: Add query constraint wherePolygonContains to determine whether a point in within a polygon #778

feat: Add query constraint wherePolygonContains to determine whether a point in within a polygon #778

Uh oh!

Conversation

Paul0Cesar commented Jul 18, 2022 • edited by mtrezza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Uh oh!

parse-github-assistant bot commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

mtrezza commented Jul 20, 2022

Uh oh!

mtrezza commented Aug 18, 2022

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

Paul0Cesar commented Sep 5, 2022

Uh oh!

mtrezza commented Sep 9, 2022

Uh oh!

mtrezza commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Paul0Cesar commented Jan 18, 2023

Uh oh!

mbfakourii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paul0Cesar commented Jan 19, 2023

Uh oh!

mbfakourii left a comment

Choose a reason for hiding this comment

Uh oh!

mtrezza left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

Paul0Cesar commented Jan 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: Add query constraint `wherePolygonContains` to determine whether a point in within a polygon #778

feat: Add query constraint `wherePolygonContains` to determine whether a point in within a polygon #778

Paul0Cesar commented Jul 18, 2022 •

edited by mtrezza

Loading

parse-github-assistant bot commented Jul 18, 2022 •

edited

Loading

codecov bot commented Aug 18, 2022 •

edited

Loading

mtrezza commented Nov 28, 2022 •

edited

Loading

mtrezza left a comment •

edited

Loading

Paul0Cesar commented Jan 21, 2023 •

edited

Loading