Skip to content

feat: Add include option to getObject and fetch #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 22, 2022
Merged

feat: Add include option to getObject and fetch #798

merged 13 commits into from
Dec 22, 2022

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Nov 16, 2022

New Pull Request Checklist

Issue Description

Added include in getObject and fetch
Added test

Related issue: #797

Approach

In ParseObject class and getObject and fetch functions there is no value include

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 16, 2022

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 11.52% // Head: 13.66% // Increases project coverage by +2.13% 🎉

Coverage data is based on head (2977b19) compared to base (2befe18).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   11.52%   13.66%   +2.13%     
==========================================
  Files          47       47              
  Lines        2846     2847       +1     
==========================================
+ Hits          328      389      +61     
+ Misses       2518     2458      -60     
Impacted Files Coverage Δ
packages/dart/lib/parse_server_sdk.dart 28.57% <ø> (ø)
packages/dart/lib/src/network/parse_query.dart 20.73% <ø> (+0.41%) ⬆️
packages/dart/lib/src/utils/parse_utils.dart 46.15% <80.00%> (+4.97%) ⬆️
packages/dart/lib/src/objects/parse_object.dart 15.78% <100.00%> (+5.21%) ⬆️
packages/dart/lib/src/objects/parse_base.dart 44.95% <0.00%> (+2.75%) ⬆️
packages/dart/lib/src/objects/parse_file.dart 4.00% <0.00%> (+4.00%) ⬆️
packages/dart/lib/src/utils/parse_encoder.dart 66.66% <0.00%> (+9.99%) ⬆️
packages/dart/lib/src/data/parse_core_data.dart 67.39% <0.00%> (+10.86%) ⬆️
packages/dart/lib/src/utils/parse_decoder.dart 37.73% <0.00%> (+24.52%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Nov 16, 2022

(Sorry for tagging everyone for review here; but we didn't get any reviews on the last PR, so I hope someone could talk a look at this)

@mtrezza mtrezza changed the title feat: Add include in getObject and fetch feat: Add include option to getObject and fetch Nov 16, 2022
@mbfakourii mbfakourii requested a review from mtrezza December 21, 2022 15:27
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the version and add the cangelog?

@mbfakourii
Copy link
Member Author

Could you bump the version and add the cangelog?

added

@mtrezza mtrezza merged commit e2d0e4e into parse-community:master Dec 22, 2022
@mbfakourii mbfakourii deleted the support_include_in_getobject_and_fetch branch May 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants