Skip to content

fix: SDK crashes due to missing error code property in ParseNetworkResponse.data #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 14, 2022
Merged

fix: SDK crashes due to missing error code property in ParseNetworkResponse.data #802

Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8a188fe
fix bug buildErrorResponse in statusCode
mbfakourii Nov 27, 2022
fed7cf3
fix lint error for dart code format
mbfakourii Nov 27, 2022
0ab1c9d
Merge branch 'master' into health_check_wrong_appid
mbfakourii Nov 27, 2022
65644a0
Back to the previous method, but with the null condition check
mbfakourii Nov 28, 2022
d5f0657
use -1 instead of ParseNetworkResponse.statusCode
mbfakourii Nov 29, 2022
60a8228
add const error code in ParseError
mbfakourii Dec 1, 2022
df66b5e
fix small bug in documentation comments
mbfakourii Dec 1, 2022
4c25b26
fix small bug in documentation comments
mbfakourii Dec 1, 2022
75b2389
Added in changelog and version increase
mbfakourii Dec 10, 2022
1872203
Back to the previous version in Flutter lib
mbfakourii Dec 10, 2022
cf78954
Update packages/dart/CHANGELOG.md
mtrezza Dec 10, 2022
477e678
Back to the previous version in Flutter lib
mbfakourii Dec 10, 2022
9864271
Merge remote-tracking branch 'origin/health_check_wrong_appid' into h…
mbfakourii Dec 10, 2022
6258446
Dart version was increased
mbfakourii Dec 10, 2022
89612ff
Update packages/dart/CHANGELOG.md
mtrezza Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/dart/lib/src/objects/response/parse_error_response.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ ParseResponse buildErrorResponse(
ParseResponse response, ParseNetworkResponse apiResponse) {
final Map<String, dynamic> responseData = json.decode(apiResponse.data);
response.error = ParseError(
code: responseData[keyCode], message: responseData[keyError].toString());
response.statusCode = responseData[keyCode];
code: responseData[keyCode] ?? -1,
message: responseData[keyError].toString());
response.statusCode = responseData[keyCode] ?? -1;
return response;
}