Skip to content

feat: Add ParseObject.toJson() to create a JSON representation #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2022
Merged

feat: Add ParseObject.toJson() to create a JSON representation #812

merged 3 commits into from
Dec 23, 2022

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Dec 22, 2022

New Pull Request Checklist

Issue Description

remove protected in toJson for use externally

Closes: #616

Approach

only remove protected in toJson

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: remove protected in toJson for use externally fix: Remove protected in toJson for use externally Dec 22, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 22, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 13.66% // Head: 13.66% // No change to project coverage 👍

Coverage data is based on head (5d28184) compared to base (e2d0e4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   13.66%   13.66%           
=======================================
  Files          47       47           
  Lines        2847     2847           
=======================================
  Hits          389      389           
  Misses       2458     2458           
Impacted Files Coverage Δ
packages/dart/lib/src/objects/parse_base.dart 44.95% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix: Remove protected in toJson for use externally feat: Expose in ParseObject.toJson() to create a JSON representation Dec 22, 2022
@mtrezza mtrezza changed the title feat: Expose in ParseObject.toJson() to create a JSON representation feat: Expose ParseObject.toJson() to create a JSON representation Dec 22, 2022
@mtrezza mtrezza changed the title feat: Expose ParseObject.toJson() to create a JSON representation feat: Add ParseObject.toJson() to create a JSON representation Dec 22, 2022
@mtrezza
Copy link
Member

mtrezza commented Dec 22, 2022

I've changed the commit type to feat, since from the developer perspective it's a new method the SDK offers.

Does the PR title make sense?

@mbfakourii
Copy link
Member Author

I've changed the commit type to feat, since from the developer perspective it's a new method the SDK offers.

Does the PR title make sense?

Yes, this title looks better

@mtrezza
Copy link
Member

mtrezza commented Dec 22, 2022

Alright, if you want to add a changelog entry and bump the version we can release.

@mbfakourii
Copy link
Member Author

Alright, if you want to add a changelog entry and bump the version we can release.

added

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 7dd2626 into parse-community:master Dec 23, 2022
@mbfakourii mbfakourii deleted the fix_toJson branch May 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameters in toString() from ParseObject
2 participants