-
-
Notifications
You must be signed in to change notification settings - Fork 207
feat: Add ParseObject.toJson()
to create a JSON representation
#812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will reformat the title to use the proper commit message syntax. |
toJson
for use externallytoJson
for use externally
Thanks for opening this pull request!
|
Codecov ReportBase: 13.66% // Head: 13.66% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #812 +/- ##
=======================================
Coverage 13.66% 13.66%
=======================================
Files 47 47
Lines 2847 2847
=======================================
Hits 389 389
Misses 2458 2458
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
toJson
for use externallyParseObject.toJson()
to create a JSON representation
ParseObject.toJson()
to create a JSON representationParseObject.toJson()
to create a JSON representation
ParseObject.toJson()
to create a JSON representationParseObject.toJson()
to create a JSON representation
I've changed the commit type to Does the PR title make sense? |
Yes, this title looks better |
Alright, if you want to add a changelog entry and bump the version we can release. |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
New Pull Request Checklist
Issue Description
remove protected in
toJson
for use externallyCloses: #616
Approach
only remove protected in
toJson
TODOs before merging