Skip to content

fix: Include option in getObject feature is not working #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 24, 2022
Merged

fix: Include option in getObject feature is not working #814

merged 4 commits into from
Dec 24, 2022

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Dec 24, 2022

New Pull Request Checklist

Issue Description

fix include in get object

Closes: #813

Approach

Use Parse SDK built-in functions to solve the problem

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: include in get object fix: Include in get object Dec 24, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 24, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mbfakourii mbfakourii changed the title fix: Include in get object fix: Include in getObject Dec 24, 2022
@codecov
Copy link

codecov bot commented Dec 24, 2022

Codecov Report

Base: 13.66% // Head: 13.63% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f6357d8) compared to base (7dd2626).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   13.66%   13.63%   -0.04%     
==========================================
  Files          47       47              
  Lines        2847     2846       -1     
==========================================
- Hits          389      388       -1     
  Misses       2458     2458              
Impacted Files Coverage Δ
packages/dart/lib/src/objects/parse_object.dart 15.41% <100.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii mbfakourii requested a review from mtrezza December 24, 2022 14:21
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add the changelog and version bump?

@mtrezza mtrezza changed the title fix: Include in getObject fix: Include option to getObject feature is not working Dec 24, 2022
@mtrezza mtrezza changed the title fix: Include option to getObject feature is not working fix: Include option in getObject feature is not working Dec 24, 2022
@mbfakourii
Copy link
Member Author

Looks good, could you add the changelog and version bump?

added

mtrezza
mtrezza previously approved these changes Dec 24, 2022
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Edit: just noticed after merging that this should have been under "Bug Fixes" not "Features" in the changelog; I'll fix that separately.

@mtrezza mtrezza merged commit 5f84a8b into parse-community:master Dec 24, 2022
@mbfakourii mbfakourii deleted the fix_getObject branch May 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature "Add include option to getObject in 3.1.7" with error for me
2 participants