-
-
Notifications
You must be signed in to change notification settings - Fork 206
fix: Dio error holds a reference to null values #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When an error occurs, the Dio error object could hold null properties causing the error (Type 'Null' is not a subtype of type 'Object')
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking nulls, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changelog entry using the PR title and bump the version? See existing entries for examples.
Lint also needs some changes.
Codecov ReportBase: 15.88% // Head: 15.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 15.88% 15.82% -0.07%
==========================================
Files 47 47
Lines 2865 2876 +11
==========================================
Hits 455 455
- Misses 2410 2421 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Waiting for CI to pass...
When an error occurs, the Dio error object could hold null properties causing the error (Type 'Null' is not a subtype of type 'Object')
New Pull Request Checklist
Issue Description
Closes: #774
Approach
Add null aware operator
??
:TODOs before merging
All set