Skip to content

refactor: Increment Flutter SDK compatibility to <4.0.0; add example project #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2023
Merged

refactor: Increment Flutter SDK compatibility to <4.0.0; add example project #884

merged 8 commits into from
May 17, 2023

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented May 14, 2023

New Pull Request Checklist

Issue Description

Add example for flutter pakage
Add screenshot
Increase the sdk environment range to 4 (base (flutter packages))
Increase the description between 60 and 180 characters
upgrade parse_server_sdk
vsync remove in #761

Closes: #882

Approach

n/a

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

increase sdk environment
add screenshots
@parse-github-assistant
Copy link

parse-github-assistant bot commented May 14, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -28.48 ⚠️

Comparison is base (d1d1830) 38.68% compared to head (9d70a1b) 10.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #884       +/-   ##
===========================================
- Coverage   38.68%   10.21%   -28.48%     
===========================================
  Files          56        5       -51     
  Lines        3278      284     -2994     
===========================================
- Hits         1268       29     -1239     
+ Misses       2010      255     -1755     

see 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii mbfakourii requested a review from a team May 14, 2023 11:10
@mbfakourii
Copy link
Member Author

mbfakourii commented May 14, 2023

It is better before this PR Merge PR #761

@mbfakourii mbfakourii changed the title Improve flutter pub points score feat: Improve flutter pub points score May 16, 2023
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title feat: Improve flutter pub points score refactor: Increment Dart SDK compatibility to <4.0.0; add example project May 17, 2023
@mtrezza mtrezza merged commit 563be8c into parse-community:master May 17, 2023
@mbfakourii mbfakourii changed the title refactor: Increment Dart SDK compatibility to <4.0.0; add example project refactor: Increment Flutter SDK compatibility to <4.0.0; add example project May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve dart pub points scoring on pub.dev
3 participants