Skip to content

refactor: Add pubspec in dart example #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2023
Merged

refactor: Add pubspec in dart example #908

merged 3 commits into from
May 19, 2023

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

add pubspec in dart example and fix main.dart example warning

Closes: #905

Approach

n/a

Tasks

n/a

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add pubspec in dart example fix: Add pubspec in dart example May 18, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii mentioned this pull request May 18, 2023
Merged
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +2.74 🎉

Comparison is base (7bfce0f) 39.13% compared to head (1a0ebad) 41.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   39.13%   41.88%   +2.74%     
==========================================
  Files          56       51       -5     
  Lines        3278     2994     -284     
==========================================
- Hits         1283     1254      -29     
+ Misses       1995     1740     -255

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented May 18, 2023 •
edited
Loading

It's a fix in the example, which is not part of the SDK itself, so this is merely a refactor and won't cause a release.

@mtrezza mtrezza changed the title fix: Add pubspec in dart example refactor: Add pubspec in dart example May 18, 2023
mtrezza
mtrezza approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready for merge?

@mbfakourii
Copy link
Member Author

Looks good, ready for merge?

Yes, I think it is ready

@Nidal-Bakir
Copy link
Member

Could you run the following command to see if there are any errors:
dart analyze packages/dart --fatal-infos

@Nidal-Bakir
Copy link
Member

I just tested it with dart analyze packages/dart --fatal-infos no issues were found. We are good to publish Dart 5.1.1

@Nidal-Bakir
Copy link
Member

See #906 (comment)

@mbfakourii mbfakourii mentioned this pull request May 19, 2023
Merged
2 tasks
@mtrezza
Copy link
Member

mtrezza commented May 19, 2023

Can this PR be merged despite the failing CI?

@mbfakourii
Copy link
Member Author

Can this PR be merged despite the failing CI?

This error is related to the version of Flutter, merge it and there will be no problem

@mtrezza mtrezza merged commit e097da5 into parse-community:master May 19, 2023
@mbfakourii mbfakourii deleted the add_pubspec_to_example branch May 23, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

@Nidal-Bakir Nidal-Bakir Nidal-Bakir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing Dart SDK 5.1.1 failed
3 participants
@mbfakourii @mtrezza @Nidal-Bakir