Skip to content

Dependabot only upgrading Parse Server #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
mtrezza opened this issue Jan 27, 2023 · 10 comments · Fixed by #1673
Closed
4 tasks done

Dependabot only upgrading Parse Server #1671

mtrezza opened this issue Jan 27, 2023 · 10 comments · Fixed by #1673
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:ci CI related issue

Comments

@mtrezza
Copy link
Member

mtrezza commented Jan 27, 2023

New Issue Checklist

Issue Description

Dependabot is only upgrading Parse Server due to a config file added to fix an issue described in #1546. The side effect is that the config disabled security upgrades of all other dependencies. This isn't a major issue since Snyk is also opening PRs for security issues. But since dependabot sometimes opens a PR for an issue that Snyk didn't detect yet, it reduces the overall security coverage.

The challenge is to figure out how to upgrade parse server with every commit (which the current config file does) while also allowing upgrades for all other repos.

Steps to reproduce

Dependabot didn't open security patches in this repo anymore as reported in #1525 (comment).

Actual Outcome

n/a

Expected Outcome

n/a

Environment

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 27, 2023

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added type:bug Impaired feature or lacking behavior that is likely assumed type:ci CI related issue and removed type:bug Impaired feature or lacking behavior that is likely assumed labels Jan 27, 2023
@dplewis
Copy link
Member

dplewis commented Jan 27, 2023

Running npm outdated on the repo shows that a lot of our packages are out of date. Dependabot or Snyx should open PR's for those not just security patches. I would love for Jasmine 4.5.0 to run against our test suites.

@mtrezza
Copy link
Member Author

mtrezza commented Jan 27, 2023

They did / should open PRs, for example #1524. The reason could be that these bots only open a limited number of PRs. If there are open, unmerged PRs they may stop new PRs being opened. That's why after closing or merging a PR almost immediately we see a new one being opened sometimes.

@dplewis
Copy link
Member

dplewis commented Jan 27, 2023

If we close those old PRs would new PRs open. Lets try it out

@mtrezza
Copy link
Member Author

mtrezza commented Jan 27, 2023

I've closed the old ones, Snyk settings look normal, checked 7 hours ago.

image

I'll try to re-add the project in Snyk, maybe it's checking a wrong branch because it doesn't find any issues.

@mtrezza
Copy link
Member Author

mtrezza commented Jan 27, 2023

Reimported the repo in Snyk; the dependencies are detected correctly. It doesn't show any vulnerabilities in the dependencies:

image

The repo uses the org setting which has update out-of-date dependencies enabled:

image

@mtrezza
Copy link
Member Author

mtrezza commented Jan 27, 2023

@dplewis responding to your #1678 (comment):

Reading the docs I assumed that all means only direct dependencies for npm. The docs also say:

Use the allow option to customize which dependencies are updated. This applies to both version and security updates.

So it seems to not be possible to differentiate between "security" and "outdated" upgrades. Maybe let's observe this a bit more. There are no new dependabot PRs being opened, so maybe it was just an initial flood of PRs.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 30, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.1-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@mtrezza mtrezza closed this as completed Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:ci CI related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants