Skip to content

refactor: upgrade ws from 8.6.0 to 8.8.1 #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Aug 9, 2022

Snyk has created this PR to upgrade ws from 8.6.0 to 8.8.1.

merge advice
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 3 versions ahead of your current version.
  • The recommended version was released 24 days ago, on 2022-07-15.
Release notes
Package name: ws
  • 8.8.1 - 2022-07-15

    Bug fixes

    • The Authorization and Cookie headers are no longer sent if the original
      request for the opening handshake is sent to an IPC server and the client is
      redirected to another IPC server (bc8bd34).
  • 8.8.0 - 2022-06-09

    Features

    • Added the WS_NO_BUFFER_UTIL and WS_NO_UTF_8_VALIDATE environment
      variables (becf237).
  • 8.7.0 - 2022-05-26

    Features

    • Added the ability to inspect the invalid handshake requests and respond to
      them with a custom HTTP response. (6e5a5ce).

    Bug fixes

    • The handshake is now aborted if the Upgrade header field value in the HTTP
      response is not a case-insensitive match for the value "websocket" (0fdcc0a).
    • The Authorization and Cookie headers are no longer sent when following an
      insecure redirect (wss: to ws:) to the same host (d68ba9e).
  • 8.6.0 - 2022-05-01

    Features

    • Added the ability to remove confidential headers on a per-redirect basis (#2030).
from ws GitHub release notes
Commit messages
Package name: ws

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title [Snyk] Upgrade ws from 8.6.0 to 8.8.1 refactor: upgrade ws from 8.6.0 to 8.8.1 Aug 9, 2022
@dplewis
Copy link
Member

dplewis commented Jan 27, 2023

@mtrezza Is dependabot working? I only see it working for parse-server bumps. We could avoid another 3.5.0 issue like #1600 in the future. I think this should be closed at we aren't using Snyx-bot

@dplewis dplewis requested a review from a team January 27, 2023 04:35
@mtrezza
Copy link
Member

mtrezza commented Jan 27, 2023

We are using both dependabot and snyk in our repos. Some security PRs are only opened by one or the other, some by both. Hence we have both enabled. We have this repo config, with non-security version upgrades disabled because Snyk is already doing that.

Some time ago we've added a dependabot config file and it seem that we've allowed it to upgrade only parse-server.

The reason for the config file is described in #1546. I've opened #1671 to figure out how to upgrade parse server with every commit while allowing upgrades for all other repos.

@mtrezza
Copy link
Member

mtrezza commented Jan 27, 2023

Closing, the conflict is too complex to resolve manually.

@mtrezza mtrezza closed this Jan 27, 2023
@mtrezza mtrezza deleted the snyk-upgrade-64e52dc70dd57f9e864e7717281f8ede branch January 27, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants