Skip to content

Exception in ParseLiveQuery in react-native #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
farwayer opened this issue Mar 20, 2016 · 6 comments
Closed

Exception in ParseLiveQuery in react-native #232

farwayer opened this issue Mar 20, 2016 · 6 comments

Comments

@farwayer
Copy link
Contributor

getSessionToken() in ParseLiveQuery calls sync currentUser() and throw exception in react-native (with async storage)

@andrewimm
Copy link
Contributor

@peterdotjs @wangmengyan95 is it possible for you to make the method in question, and whatever's calling it async? All current user fetching internally should be using the async methods, to support async storage systems.

@peterdotjs
Copy link
Contributor

@andrewimm I'll make the change to use currentUserAsync.

@andrewimm
Copy link
Contributor

Okay, my concern is that the caller functions might be synchronous, and APIs would need to change to adjust for this.

@peterdotjs
Copy link
Contributor

Currently we're using currentUser to init the DefaultLiveQueryClient here. But we are using the sessionToken again here. Assuming we want to query for the token on each subscribe the interface for LiveQueryClient.subscribe will need to change. @wangmengyan95

@farwayer
Copy link
Contributor Author

Thanks for fast response guys. I found one more bug with WebSockets implementation in react-native. Look like live queries are not very popular in RN :)
PR #233

@stale
Copy link

stale bot commented Feb 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 6, 2019
@stale stale bot closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants