Updating Parse.LiveQuery to use currentUserAsync.

[peterdotjs]

Addressing #232.

[codecov-io]

Current coverage is 79.84%

Merging #234 into master will increase coverage by +0.04% as of eac5d4b

@@            master    #234   diff @@
======================================
  Files           40      40       
  Stmts         3278    3279     +1
  Branches       775     776     +1
  Methods          0       0       
======================================
+ Hit           2616    2618     +2
+ Partial        230     229     -1
  Missed         432     432       

Review entire Coverage Diff as of eac5d4b

Powered by Codecov. Updated on successful CI builds.

[wangmengyan95]

It is wired to create promiseXXX for each inner promises, why not just chain them?

[wangmengyan95]

Any reason you want to keep this?

[peterdotjs]

what is the issue here? I thought it's more readable than chaining directly from the above.

[yonahforst]

I tried this out in my react-native app. query.subscribe() now returns a promise and the following example fails:

        let subscription = query.subscribe()
        subscription.on('open', () => {
            console.log('subscription opened');
        });

[peterdotjs]

I'm working on changing this to keep the interface the same - when landed .subscribe will return a subscription.

Sent from my iPhone

On Mar 22, 2016, at 7:04 AM, Yonah Forst [email protected] wrote:

I tried this out in my react-native app. query.subscribe() now returns a promise and the following example fails:

    let subscription = query.subscribe()
    subscription.on('open', () => {
        console.log('subscription opened');
    });

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[wangmengyan95]

Do we need this? I think the arrow function auto bind this for you?

[peterdotjs]

arrow does auto bind but in this case we'll need to distinguish between the promise and the subscription context.