Skip to content

fix(AddUniqueOp): Remove unnecessary object reference and comment #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 10, 2020

Addresses: #443

Removing this to prevent confusion. Does anybody want to explain why this is needed? Its been there since the beginning of the SDK

Addresses: #443

Removing this to prevent confusion. Does anybody want to explain why this is needed?
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1253 (ac8d3c6) into master (6298673) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          57       57           
  Lines        5401     5400    -1     
  Branches     1198     1198           
=======================================
- Hits         5400     5399    -1     
  Misses          1        1           
Impacted Files Coverage Δ
src/ParseOp.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6298673...ac8d3c6. Read the comment docs.

@dplewis dplewis changed the title fix(AddUniqueOp): Remove unnessary object reference and comment fix(AddUniqueOp): Remove unnecessary object reference and comment Nov 10, 2020
@davimacedo davimacedo merged commit e155079 into master Nov 10, 2020
@dplewis dplewis deleted the adduniqueop-ref branch November 10, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants