fix: Internal Referencing for Increment Dot Notation #1255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is building upon #1219, together they solve the following issues.
There was a internal referencing issue that resulted in the increment to happen every time you get the attributes
Lucky this
.get
returns the proper value so clients aren't affected. (Fixed in this PR).When you save with increment there is an extra attribute returned from _handleSaveResponse (Fixed in #1219)
When saving after using increment nested, the full object isn't returned. (Fixed in #1219)
When merged with the server this will work in beforeSave / afterSaves hooks.