Skip to content

Make sure the className is correct for results on unknown relations #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2016

Conversation

andrewimm
Copy link
Contributor

If the target className of a relation is not known ahead of time, and the server does not pass the className back on the raw JSON of Parse Object results, the query results end up with the wrong className.
The className to be used comes back as a top-level key on the query result payload. This diff makes sure that value is used, if available.

@codecov-io
Copy link

Current coverage is 79.55%

Merging #179 into master will increase coverage by +0.08% as of 94eed4c

@@            master    #179   diff @@
======================================
  Files           39      39       
  Stmts         2997    2998     +1
  Branches       713     714     +1
  Methods          0       0       
======================================
+ Hit           2382    2385     +3
+ Partial        200     197     -3
- Missed         415     416     +1

Review entire Coverage Diff as of 94eed4c

Powered by Codecov. Updated on successful CI builds.

peterdotjs added a commit that referenced this pull request Jan 22, 2016
Make sure the className is correct for results on unknown relations
@peterdotjs peterdotjs merged commit a292f58 into master Jan 22, 2016
@peterdotjs
Copy link
Contributor

lgtm.

@andrewimm andrewimm mentioned this pull request Jan 25, 2016
5 tasks
@andrewimm andrewimm deleted the relation_classname branch January 25, 2016 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants