Skip to content

refactor: Run ESLint against TypeScript files #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 17, 2024

Pull Request

Issue

Linting currently only runs on TS declaration files (.d.ts) and not on the TS files themselves.

Closes: #2070

Approach

Bump eslint to 8.56.0, replace babel parse with typescript parser. This also fixes dtslint parser.

Convert the following files to TS

Cloud.js
LiveQueryClient
LocalDatastore
LocalDatastoreController.default
LocalDatastoreController.react-native
LocalDatastoreUtils
ParseCLP

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (bd51015).
Report is 43 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2135    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6345   +159     
  Branches      1499      1521    +22     
==========================================
+ Hits          6186      6345   +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team May 17, 2024 01:03
@mtrezza mtrezza mentioned this pull request May 17, 2024
66 tasks
@mtrezza mtrezza merged commit dbf9c91 into parse-community:alpha May 17, 2024
10 of 11 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 17, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 24, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants