Skip to content

refactor: Remove Flow Type #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 20, 2024

Pull Request

Issue

Now that all files have been converted to typescript we no longer need flow types. To get flow type to work you would have to install flow-bin globally unlike parse server which runs flow along with eslint.

Approach

Remove @flow comment from files and remove all flow type plugins

Convert the following files to TS

EventuallyQueue
IndexDBStorageController
LiveQuerySubscription
ParseACL
ParseError
ParseLiveQuery
ParseRelation
SingleInstanceStateController
UniqueInstanceStateController

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dplewis dplewis requested a review from a team May 20, 2024 00:48
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b50790a) to head (46f93cf).
Report is 51 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha     #2145    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           61        64     +3     
  Lines         6186      6360   +174     
  Branches      1499      1534    +35     
==========================================
+ Hits          6186      6360   +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis mentioned this pull request May 20, 2024
66 tasks
@mtrezza mtrezza merged commit 31796f3 into parse-community:alpha May 20, 2024
11 checks passed
@dplewis dplewis deleted the remove-flow branch May 20, 2024 13:40
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 7, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 24, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants