Skip to content

Fix 'events' resolution issue #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016
Merged

Fix 'events' resolution issue #240

merged 1 commit into from
Mar 24, 2016

Conversation

andrewimm
Copy link
Contributor

This should make sure that EventEmitter is properly initialized on every platform and build. The code for parse-latest looks correct, as do the lib builds, but please test this thoroughly.

@andrewimm
Copy link
Contributor Author

cc @wangmengyan95 @peterdotjs

@codecov-io
Copy link

Current coverage is 79.95%

Merging #240 into master will increase coverage by +0.07% as of 5a151af

@@            master    #240   diff @@
======================================
  Files           40      40       
  Stmts         3272    3272       
  Branches       773     773       
  Methods          0       0       
======================================
+ Hit           2614    2616     +2
+ Partial        230     227     -3
- Missed         428     429     +1

Review entire Coverage Diff as of 5a151af

Powered by Codecov. Updated on successful CI builds.

@peterdotjs peterdotjs self-assigned this Mar 24, 2016
@peterdotjs
Copy link
Contributor

thanks @andrewimm I'll test it out

@wangmengyan95
Copy link
Contributor

LGTM. Thanks @andrewimm .

@peterdotjs
Copy link
Contributor

LGTM as well.

@peterdotjs peterdotjs merged commit f17befd into master Mar 24, 2016
@dplewis dplewis deleted the events-fix branch March 21, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants