fix: Parse.Hooks requests have double forward slash in URL
#2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2441 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6256 6256
Branches 1476 1476
=========================================
Hits 6256 6256 ☔ View full report in Codecov by Sentry. |
mtrezza
approved these changes
Feb 12, 2025
|
Could this possibly be a breaking change, thinking about custom parsing of the URI on the server or firewall? |
|
We might want to merge this as a breaking change, make a stable release and then add that to the Parse Sever 8 release as a breaking change. Even though these are internal requests and therefore may be less likely to be restricted by a firewall, it's still possible. |
mtrezza
added
the
state:breaking
mtrezza
requested changes
Feb 16, 2025
mtrezza
approved these changes
Feb 16, 2025
|
BREAKING CHANGE: Internal REST requests for @dplewis Is this correct? |
|
LGTM! |
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 16, 2025
# [6.0.0-alpha.2](6.0.0-alpha.1...6.0.0-alpha.2) (2025-02-16) ### Bug Fixes * `Parse.Hooks` requests have double forward slash in URL ([#2441](#2441)) ([1fc520c](1fc520c)) ### BREAKING CHANGES * Internal REST requests for `Parse.Hooks` use a URL that contains a double forward slash, for example `http://localhost/parse//hooks/functions`. This release changes the double forward slash to a single forward slash. ([1fc520c](1fc520c))
|
🎉 This change has been released in version 6.0.0-alpha.2 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 2, 2025
# [6.0.0](5.3.0...6.0.0) (2025-03-02) ### Bug Fixes * `Parse.Hooks` requests have double forward slash in URL ([#2441](#2441)) ([1fc520c](1fc520c)) * `Parse.Query.findAll` not returning all objects with option `json: true` ([#2449](#2449)) ([f160b8c](f160b8c)) * Cannot pass `useMasterKey: false` to `Parse.Cloud.run` ([#2431](#2431)) ([abadac9](abadac9)) * Remove validation error handler option `error` from various methods of `Parse.Object` ([#2445](#2445)) ([52ddaee](52ddaee)) * Security upgrade dset from 3.1.3 to 3.1.4 ([#2277](#2277)) ([058f8e4](058f8e4)) ### Features * Add transaction to save and destroy on `Parse.Object` ([#2265](#2265)) ([2b55bdf](2b55bdf)) ### BREAKING CHANGES * Internal REST requests for `Parse.Hooks` use a URL that contains a double forward slash, for example `http://localhost/parse//hooks/functions`. This release changes the double forward slash to a single forward slash. ([1fc520c](1fc520c)) * Removes the error handler option `error` from `Parse.Object.set`, `Parse.Object.setACL`, `Parse.Object.unset`, `Parse.Role.setName` and instead throws on validation error. Previously, if the `error` option was set, the handler was invoked if a validation error occurred on `Parse.Object.set`, and if no handler was set, an error was thrown on `Parse.Object.save`. The new behavior is that an error is thrown at `Parse.Object.set`. For example, instead of using `Parse.Object.set(key, value, { error: ... })` wrap `Parse.Object.set(key, value)` into a `try/catch` block. ([52ddaee](52ddaee))
|
🎉 This change has been released in version 6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: #2406
Approach
Remove extra slash
Tasks