Skip to content

Support for Aggregate Queries #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 30, 2017
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 1, 2017

Support for distinct() and aggregate() queries.

Pending: parse-community/parse-server#4207

@oallouch
Copy link
Contributor

oallouch commented Oct 2, 2017

That's really great. All the power of MongoDB in Parse !
Do you have prepared a little documentation update for this ?

@dplewis
Copy link
Member Author

dplewis commented Oct 2, 2017

@oallouch Documentation will be coming soon!

@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #485 into master will increase coverage by 0.06%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   84.03%   84.09%   +0.06%     
==========================================
  Files          47       47              
  Lines        3801     3830      +29     
  Branches      869      875       +6     
==========================================
+ Hits         3194     3221      +27     
- Misses        607      609       +2
Impacted Files Coverage Δ
src/CoreManager.js 100% <100%> (ø) ⬆️
src/ParseQuery.js 94.01% <93.1%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a209282...7e506c9. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Nov 29, 2017

@flovilmart Can you check this?

@flovilmart
Copy link
Contributor

code looks good, but would it be too much to ask for added Jest tests for this class?

@flovilmart
Copy link
Contributor

Thanks @dplewis for this! 🙏

@dplewis
Copy link
Member Author

dplewis commented Nov 30, 2017

@flovilmart Quick question. I was lazy and didn't require aggregate in the query controller https://github.com/dplewis/Parse-SDK-JS/blob/aggregate/src/CoreManager.js#L272

Is that ok? I can update all the tests if needed.

@flovilmart
Copy link
Contributor

That would be better to add those methods now so we don’t have to come back to it later.

@flovilmart
Copy link
Contributor

CoreManager-test is failing (it specifically validates the interface)

@flovilmart
Copy link
Contributor

Perfect! Waiting for CI but it all looks great!

@dplewis
Copy link
Member Author

dplewis commented Nov 30, 2017

@flovilmart How does this look?

@flovilmart
Copy link
Contributor

Perfect 👌🏻

@flovilmart flovilmart merged commit a712abb into parse-community:master Nov 30, 2017
@dplewis dplewis deleted the aggregate branch November 30, 2017 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants