-
-
Notifications
You must be signed in to change notification settings - Fork 596
Support for Aggregate Queries #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's really great. All the power of MongoDB in Parse ! |
@oallouch Documentation will be coming soon! |
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 84.03% 84.09% +0.06%
==========================================
Files 47 47
Lines 3801 3830 +29
Branches 869 875 +6
==========================================
+ Hits 3194 3221 +27
- Misses 607 609 +2
Continue to review full report at Codecov.
|
@flovilmart Can you check this? |
code looks good, but would it be too much to ask for added Jest tests for this class? |
Thanks @dplewis for this! 🙏 |
@flovilmart Quick question. I was lazy and didn't require aggregate in the query controller https://github.com/dplewis/Parse-SDK-JS/blob/aggregate/src/CoreManager.js#L272 Is that ok? I can update all the tests if needed. |
That would be better to add those methods now so we don’t have to come back to it later. |
CoreManager-test is failing (it specifically validates the interface) |
Perfect! Waiting for CI but it all looks great! |
@flovilmart How does this look? |
Perfect 👌🏻 |
Support for
distinct()
andaggregate()
queries.Pending: parse-community/parse-server#4207