Adds interface to externally set RN Async Storage #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanrolnik
approved these changes
Dec 2, 2017
|
@natanrolnik not sure what's going on with travis, I'm on the good base, and it's failing for no good reason :/ odd |
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 84.58% 84.59% +<.01%
==========================================
Files 48 48
Lines 3951 3952 +1
Branches 897 897
==========================================
+ Hits 3342 3343 +1
Misses 609 609
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #508
closes #496
closes #418
closes #515
And once and for all all ReactNative async storage issues!