Support Fetch With Include #631
Conversation
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 85.12% 85.53% +0.41%
==========================================
Files 48 48
Lines 3865 3899 +34
Branches 871 882 +11
==========================================
+ Hits 3290 3335 +45
+ Misses 575 564 -11
Continue to review full report at Codecov.
|
src/ParseObject.js
Outdated
| * @param {Object} options | ||
| * @static | ||
| */ | ||
| static fetchAllWithInclude(list: Array<ParseObject>, keys: String|Array<string|Array<string>>, options: RequestOptions) { |
There was a problem hiding this comment.
why do we add more things like those warppers? semms un necessary if it's properly documented in the RequestOptions.
There was a problem hiding this comment.
I'm sorry I'm not following. How should it be?
I like shorthand but we could leave it like
obj.fetch({ include: ['key1', 'key2',...] })
There was a problem hiding this comment.
Yeah, that was my point, but we can keep the nice interfaces also, i don’t mind
|
@flovilmart I added documentation for the |
|
There was one small nit :) |
|
Nit? Where? |
src/ParseObject.js
Outdated
| return CoreManager.getObjectController().fetch( | ||
| list, | ||
| true, | ||
| queryOptions | ||
| ); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Small nit: remove one space
There was a problem hiding this comment.
Here. Sorry, forgot to hit ‘comment’ at the end of the review
There was a problem hiding this comment.
Can we add eslint to this project at some point? It looks like it would be a lot of work tho :/
There was a problem hiding this comment.
Nobody will ever hate you for adding it.
|
Is this change documented? |
|
https://parseplatform.org/Parse-SDK-JS/api/2.1.0/Parse.Object.html#fetchWithInclude If you want to update the guide feel free to open a PR |
|
Hello @dplewis is there any way by using |
|
You should be able to pass in ‘*’ |
|
Hey @dplewis thanks for the help! That worked! |
Added
fetchWithIncludeandfetchAllWithIncludeto Parse Object.Added
fetchWithIncludeto UserAs discussed parse-community/parse-server#4845 (comment)