Skip to content

Support containedBy Query #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2018
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 10, 2018

parse-community/parse-server#4766

Might have to change the name and the documentation for this one.

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #633 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   85.07%   85.08%   +<.01%     
==========================================
  Files          48       48              
  Lines        3853     3855       +2     
  Branches      871      871              
==========================================
+ Hits         3278     3280       +2     
  Misses        575      575
Impacted Files Coverage Δ
src/ParseQuery.js 94.54% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506bc83...1e316fe. Read the comment docs.

@dplewis dplewis requested a review from flovilmart August 10, 2018 15:09
@dplewis
Copy link
Member Author

dplewis commented Aug 11, 2018

@flovilmart How does this look?

Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work on Postgres as well as of today?

@dplewis
Copy link
Member Author

dplewis commented Aug 11, 2018

Yep

@flovilmart
Copy link
Contributor

Wonderful then! Merge ahead!

@dplewis dplewis merged commit 4fd73b0 into parse-community:master Aug 12, 2018
@dplewis dplewis deleted the containedBy branch August 12, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants