Support nor Query #634
Support nor Query #634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 85.08% 85.12% +0.03%
==========================================
Files 48 48
Lines 3855 3865 +10
Branches 871 871
==========================================
+ Hits 3280 3290 +10
Misses 575 575
Continue to review full report at Codecov.
|
|
@flovilmart How does this look? |
src/ParseQuery.js
Outdated
| * @param {...Parse.Query} var_args The list of queries to AND. | ||
| * @static | ||
| * @return {Parse.Query} The query that is the AND of the passed in queries. | ||
| */ |
There was a problem hiding this comment.
Is there a jsdocs checker / linter we can add?
There was a problem hiding this comment.
I mean the text in the docs ;) it says AND as it should says NOR. :)
There was a problem hiding this comment.
The PHP SDK has a document checker. In this case the @param is wrong also
There was a problem hiding this comment.
Not sure about that, you should look at them with npm run docs.
My point was on the whole documentation that it didn’t match what the function was doing
src/ParseQuery.js
Outdated
| @@ -250,6 +249,20 @@ class ParseQuery { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Adds constraint that all of the passed in queries match. | |||
There was a problem hiding this comment.
What should this be changed to?
There was a problem hiding this comment.
It should say:
‘Adds constraint that none of the passed queries match’
parse-community/parse-server#4768