-
-
Notifications
You must be signed in to change notification settings - Fork 595
Add ability to ignore validation on Parse.Object constructor/set() #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to ignore validation on Parse.Object constructor/set() #74
Conversation
Current coverage is
|
The coverage tool doesn't seem to understand the constructor arguments being split into multiple lines. Cest la vies, eh? |
fd8bcd2
to
02a339c
Compare
@@ -627,7 +631,7 @@ export default class ParseObject { | |||
|
|||
// Validate changes | |||
var validation = this.validate(newValues); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought: it might make more sense to wrap this entire var validation = ...; if (...) {}
block in an
if (!options.ignoreValidation)
statement. That way, we don't needlessly run the validation logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for sure. I'll update the request.
02a339c
to
f823344
Compare
I'm also not thrilled with the API. I think a |
f26bd9a
to
8abbc52
Compare
8abbc52
to
e7e42a5
Compare
Bump, lets get this rocking and rolling. I'd like to update our codebase without fear that this isn't going into the SDK. If there are issues or concerns lets discuss. |
I like it. I think every entry point is covered (there are a lot of constructors due to supporting the old |
Add ability to ignore validation on Parse.Object constructor/set()
This is an attempt to resolve the first blocker in #73.
Not sure if the Flow typing is correct but I'm sure you'll let me know if it is not.